This squashes 13 commits from ma/staging plus a small docstring translation
into a single coherent unit. Three workstreams.
== RBAC v13 redesign ==
- Drops core.viewer/analyst/km_admin/admin hierarchy and the
internal_roles / group_mappings / user_role_grants / plugin_access tables.
- Replaced by user_group_members + resource_grants. Atomic v12→v13 backfill
wrapped in BEGIN/COMMIT; ROLLBACK leaves schema_version at 12 for retry.
- Two authorization primitives in app.auth.access:
require_admin — Admin-group god-mode
require_resource_access(rt, "{path}") — entity-scoped grants
Single DB lookup per request; no session cache; no implies BFS.
- /admin/access UI (single page) replaces /admin/role-mapping +
/admin/plugin-access. CLI `da admin group/grant *` replaces
`da admin role/mapping/grant-role/revoke-role/effective-roles`.
- ResourceType.TABLE listing-only — admins can record table grants,
runtime enforcement still flows through legacy dataset_permissions
(migration plan in docs/TODO-rbac-data-enforcement.md).
== Claude Code marketplace ==
- Aggregated /marketplace.zip + /marketplace.git/* (PAT-gated,
RBAC-filtered, content-addressed cache via dulwich).
- Admin god-mode dropped on the marketplace surface — admins curate
their own view via grants like everyone else.
- Bare-repo cache materializes per RBAC-filtered ETag; stale entries
not pruned in this iteration (disclaimed in git_backend.py docstring).
== #81 #83 #44 security/ops hardening ==
- #81 Group A — orchestrator ATTACH allow-listing (extension/url/alias).
- #81 Group B — Keboola extractor 3-state exit codes:
0 success / 1 total fail / 2 PARTIAL fail
Sync API logs PARTIAL FAILURE alert on exit 2. Operators with binary
alerting must teach it the new partial signal.
- #81 Group C — schema v10 view_ownership; rejects silent overwrite
of a prior connector's view name on collision.
- #81 Group D — extractor-side identifier validation.
- #83 — Jira webhook fail-closed when JIRA_WEBHOOK_SECRET unset
+ path-traversal fix.
- #44 — entire /api/scripts/* surface is admin-only (planted-script +
sandbox-bypass risk closed).
== Web UI polish + deploy fix ==
- /admin/access: live grant-count badges (no stale snapshot revert),
shared-header CSS link added to /catalog and /admin/{tables,permissions},
per-resource-type colored stripes.
- docker-compose.host-mount.yml: bind,rbind so dual-disk hosts don't
silently shadow sub-mounts and write state to the wrong disk.
== OSS vendor-neutralization (waves 1+2) ==
- scripts/grpn/ → scripts/ops/. Customer-specific identifiers
(project IDs, internal hostnames, dev/prod VM IPs, brand names)
replaced with placeholders across code, docs, Terraform, Caddyfile,
OAuth probe, and planning docs. Downstream infra repos that copied
scripts/grpn/agnes-tls-rotate.sh or agnes-auto-upgrade.sh must
update the path.
== Translation ==
- src/repositories/user_groups.py::ensure_system docstring translated
from Czech to English for codebase consistency.
Co-authored-by: Mina Rustamyan <mina@keboola.com>
312 lines
9.5 KiB
Python
312 lines
9.5 KiB
Python
"""Corporate memory endpoints — knowledge items, voting, governance admin."""
|
|
|
|
import uuid
|
|
from typing import Optional, List
|
|
|
|
from fastapi import APIRouter, Depends, HTTPException
|
|
from pydantic import BaseModel
|
|
import duckdb
|
|
|
|
from app.auth.access import require_admin
|
|
from app.auth.dependencies import get_current_user, _get_db
|
|
from src.repositories.knowledge import KnowledgeRepository
|
|
from src.repositories.audit import AuditRepository
|
|
|
|
router = APIRouter(prefix="/api/memory", tags=["memory"])
|
|
|
|
VALID_STATUSES = ["pending", "approved", "mandatory", "rejected", "revoked", "expired"]
|
|
|
|
|
|
class CreateKnowledgeRequest(BaseModel):
|
|
title: str
|
|
content: str
|
|
category: str
|
|
tags: Optional[List[str]] = None
|
|
|
|
|
|
class VoteRequest(BaseModel):
|
|
vote: int
|
|
|
|
|
|
class AdminActionRequest(BaseModel):
|
|
reason: Optional[str] = None
|
|
audience: Optional[str] = None
|
|
|
|
|
|
class EditRequest(BaseModel):
|
|
title: Optional[str] = None
|
|
content: Optional[str] = None
|
|
|
|
|
|
class BatchActionRequest(BaseModel):
|
|
item_ids: List[str]
|
|
action: str # approve, reject, mandate, revoke
|
|
reason: Optional[str] = None
|
|
audience: Optional[str] = None
|
|
|
|
|
|
# ---- User endpoints ----
|
|
|
|
@router.get("")
|
|
async def list_knowledge(
|
|
status_filter: Optional[str] = None,
|
|
category: Optional[str] = None,
|
|
search: Optional[str] = None,
|
|
page: int = 1,
|
|
per_page: int = 50,
|
|
sort: str = "updated_at",
|
|
user: dict = Depends(get_current_user),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
"""List knowledge items with filtering, pagination, search."""
|
|
repo = KnowledgeRepository(conn)
|
|
offset = (page - 1) * per_page
|
|
if search:
|
|
items = repo.search(search)
|
|
else:
|
|
statuses = [status_filter] if status_filter else None
|
|
items = repo.list_items(statuses=statuses, category=category, limit=per_page, offset=offset)
|
|
|
|
# Enrich with votes
|
|
for item in items:
|
|
votes = repo.get_votes(item["id"])
|
|
item["upvotes"] = votes["upvotes"]
|
|
item["downvotes"] = votes["downvotes"]
|
|
item["score"] = votes["upvotes"] - votes["downvotes"]
|
|
|
|
return {"items": items, "count": len(items), "page": page, "per_page": per_page}
|
|
|
|
|
|
@router.get("/stats")
|
|
async def get_stats(
|
|
user: dict = Depends(get_current_user),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
"""Get corporate memory statistics."""
|
|
repo = KnowledgeRepository(conn)
|
|
all_items = repo.list_items(limit=10000)
|
|
status_counts = {}
|
|
categories = set()
|
|
for item in all_items:
|
|
s = item.get("status", "unknown")
|
|
status_counts[s] = status_counts.get(s, 0) + 1
|
|
if item.get("category"):
|
|
categories.add(item["category"])
|
|
return {
|
|
"total": len(all_items),
|
|
"by_status": status_counts,
|
|
"categories": sorted(categories),
|
|
}
|
|
|
|
|
|
@router.post("", status_code=201)
|
|
async def create_knowledge(
|
|
request: CreateKnowledgeRequest,
|
|
user: dict = Depends(get_current_user),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
repo = KnowledgeRepository(conn)
|
|
item_id = str(uuid.uuid4())
|
|
repo.create(
|
|
id=item_id,
|
|
title=request.title,
|
|
content=request.content,
|
|
category=request.category,
|
|
source_user=user.get("email"),
|
|
tags=request.tags,
|
|
)
|
|
return {"id": item_id, "status": "pending"}
|
|
|
|
|
|
@router.post("/{item_id}/vote")
|
|
async def vote_knowledge(
|
|
item_id: str,
|
|
request: VoteRequest,
|
|
user: dict = Depends(get_current_user),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
if request.vote not in (1, -1):
|
|
raise HTTPException(status_code=400, detail="Vote must be 1 or -1")
|
|
repo = KnowledgeRepository(conn)
|
|
if not repo.get_by_id(item_id):
|
|
raise HTTPException(status_code=404, detail="Knowledge item not found")
|
|
repo.vote(item_id, user["id"], request.vote)
|
|
return repo.get_votes(item_id)
|
|
|
|
|
|
@router.get("/my-votes")
|
|
async def get_my_votes(
|
|
user: dict = Depends(get_current_user),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
"""Get current user's votes on all items."""
|
|
results = conn.execute(
|
|
"SELECT item_id, vote FROM knowledge_votes WHERE user_id = ?", [user["id"]]
|
|
).fetchall()
|
|
return {row[0]: row[1] for row in results}
|
|
|
|
|
|
# ---- Admin governance endpoints ----
|
|
|
|
def _get_item_or_404(repo: KnowledgeRepository, item_id: str) -> dict:
|
|
item = repo.get_by_id(item_id)
|
|
if not item:
|
|
raise HTTPException(status_code=404, detail="Knowledge item not found")
|
|
return item
|
|
|
|
|
|
def _audit_action(conn, admin_email: str, action: str, item_id: str, details: dict = None):
|
|
audit = AuditRepository(conn)
|
|
audit.log(user_id=admin_email, action=f"km_{action}", resource=item_id, params=details)
|
|
|
|
|
|
@router.post("/admin/approve")
|
|
async def admin_approve(
|
|
item_id: str,
|
|
user: dict = Depends(require_admin),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
repo = KnowledgeRepository(conn)
|
|
_get_item_or_404(repo, item_id)
|
|
repo.update_status(item_id, "approved")
|
|
_audit_action(conn, user["email"], "approve", item_id)
|
|
return {"id": item_id, "status": "approved"}
|
|
|
|
|
|
@router.post("/admin/reject")
|
|
async def admin_reject(
|
|
item_id: str,
|
|
request: AdminActionRequest,
|
|
user: dict = Depends(require_admin),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
repo = KnowledgeRepository(conn)
|
|
_get_item_or_404(repo, item_id)
|
|
repo.update_status(item_id, "rejected")
|
|
_audit_action(conn, user["email"], "reject", item_id, {"reason": request.reason})
|
|
return {"id": item_id, "status": "rejected"}
|
|
|
|
|
|
@router.post("/admin/mandate")
|
|
async def admin_mandate(
|
|
item_id: str,
|
|
request: AdminActionRequest,
|
|
user: dict = Depends(require_admin),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
repo = KnowledgeRepository(conn)
|
|
_get_item_or_404(repo, item_id)
|
|
repo.update_status(item_id, "mandatory")
|
|
_audit_action(conn, user["email"], "mandate", item_id, {
|
|
"reason": request.reason, "audience": request.audience,
|
|
})
|
|
return {"id": item_id, "status": "mandatory"}
|
|
|
|
|
|
@router.post("/admin/revoke")
|
|
async def admin_revoke(
|
|
item_id: str,
|
|
request: AdminActionRequest,
|
|
user: dict = Depends(require_admin),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
repo = KnowledgeRepository(conn)
|
|
_get_item_or_404(repo, item_id)
|
|
repo.update_status(item_id, "revoked")
|
|
_audit_action(conn, user["email"], "revoke", item_id, {"reason": request.reason})
|
|
return {"id": item_id, "status": "revoked"}
|
|
|
|
|
|
@router.post("/admin/edit")
|
|
async def admin_edit(
|
|
item_id: str,
|
|
request: EditRequest,
|
|
user: dict = Depends(require_admin),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
repo = KnowledgeRepository(conn)
|
|
_get_item_or_404(repo, item_id)
|
|
updates = {}
|
|
if request.title is not None:
|
|
updates["title"] = request.title
|
|
if request.content is not None:
|
|
updates["content"] = request.content
|
|
if updates:
|
|
repo.update(item_id, **updates)
|
|
_audit_action(conn, user["email"], "edit", item_id, updates)
|
|
return {"id": item_id, "updated": list(updates.keys())}
|
|
|
|
|
|
@router.post("/admin/batch")
|
|
async def admin_batch(
|
|
request: BatchActionRequest,
|
|
user: dict = Depends(require_admin),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
"""Batch governance action on multiple items."""
|
|
repo = KnowledgeRepository(conn)
|
|
action_map = {
|
|
"approve": "approved",
|
|
"reject": "rejected",
|
|
"mandate": "mandatory",
|
|
"revoke": "revoked",
|
|
}
|
|
if request.action not in action_map:
|
|
raise HTTPException(status_code=400, detail=f"Invalid action: {request.action}")
|
|
|
|
new_status = action_map[request.action]
|
|
results = {"success": [], "not_found": []}
|
|
for item_id in request.item_ids:
|
|
item = repo.get_by_id(item_id)
|
|
if not item:
|
|
results["not_found"].append(item_id)
|
|
continue
|
|
repo.update_status(item_id, new_status)
|
|
_audit_action(conn, user["email"], request.action, item_id, {
|
|
"reason": request.reason, "audience": request.audience, "batch": True,
|
|
})
|
|
results["success"].append(item_id)
|
|
|
|
return results
|
|
|
|
|
|
@router.get("/admin/pending")
|
|
async def admin_pending(
|
|
category: Optional[str] = None,
|
|
page: int = 1,
|
|
per_page: int = 50,
|
|
user: dict = Depends(require_admin),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
"""Get pending items queue for admin review."""
|
|
repo = KnowledgeRepository(conn)
|
|
offset = (page - 1) * per_page
|
|
items = repo.list_items(statuses=["pending"], category=category, limit=per_page, offset=offset)
|
|
return {"items": items, "count": len(items)}
|
|
|
|
|
|
@router.get("/admin/audit")
|
|
async def admin_audit(
|
|
page: int = 1,
|
|
per_page: int = 50,
|
|
action: Optional[str] = None,
|
|
user: dict = Depends(require_admin),
|
|
conn: duckdb.DuckDBPyConnection = Depends(_get_db),
|
|
):
|
|
"""Get governance audit log."""
|
|
audit = AuditRepository(conn)
|
|
# Filter km_ prefixed actions
|
|
km_action = f"km_{action}" if action else None
|
|
entries = audit.query(action=km_action, limit=per_page)
|
|
if not km_action:
|
|
# Get all km_ actions
|
|
entries = conn.execute(
|
|
"SELECT * FROM audit_log WHERE action LIKE 'km_%' ORDER BY timestamp DESC LIMIT ?",
|
|
[per_page],
|
|
).fetchall()
|
|
if entries:
|
|
columns = [desc[0] for desc in conn.description]
|
|
entries = [dict(zip(columns, row)) for row in entries]
|
|
else:
|
|
entries = []
|
|
return {"entries": entries, "count": len(entries)}
|