214 lines
8.7 KiB
Python
214 lines
8.7 KiB
Python
"""Tests for cli/lib/hooks.py:install_claude_hooks."""
|
|
|
|
import json
|
|
from pathlib import Path
|
|
|
|
|
|
from cli.lib.hooks import install_claude_hooks
|
|
|
|
|
|
def _read_settings(workspace: Path) -> dict:
|
|
return json.loads((workspace / ".claude" / "settings.json").read_text())
|
|
|
|
|
|
def _commands_for(cfg: dict, event: str) -> list[str]:
|
|
"""Flatten the per-event command list — each entry has a list of hooks,
|
|
each hook has a `command` field. We treat each entry as one command for
|
|
assertion purposes (matches the install_claude_hooks contract: one
|
|
entry per command)."""
|
|
return [
|
|
entry["hooks"][0]["command"]
|
|
for entry in cfg["hooks"].get(event, [])
|
|
if entry.get("hooks")
|
|
]
|
|
|
|
|
|
def test_install_creates_settings_file(tmp_path):
|
|
install_claude_hooks(tmp_path)
|
|
cfg = _read_settings(tmp_path)
|
|
starts = _commands_for(cfg, "SessionStart")
|
|
# SessionStart has two entries: (1) chained self-upgrade ; pull —
|
|
# self-upgrade runs first so a wire-protocol bump lands before pull
|
|
# tries to use the new CLI; (2) refresh-marketplace as a separate
|
|
# entry so a failure (e.g. fresh workspace with no clone) doesn't
|
|
# suppress the data pull above.
|
|
assert len(starts) == 2
|
|
chain = next(
|
|
(c for c in starts if "agnes self-upgrade" in c and "agnes pull" in c),
|
|
None,
|
|
)
|
|
assert chain is not None, (
|
|
"Expected one SessionStart entry chaining self-upgrade and pull"
|
|
)
|
|
assert "agnes self-upgrade --quiet" in chain
|
|
assert "agnes pull --quiet" in chain
|
|
# The refresh-marketplace command is wrapped in `bash -c "..."` so the
|
|
# `2>/dev/null || true` shell syntax is interpreted on Windows, where
|
|
# Claude Code runs hook commands directly without invoking a shell.
|
|
refresh = next((c for c in starts if "agnes refresh-marketplace" in c), None)
|
|
assert refresh is not None
|
|
assert refresh.startswith("bash -c "), (
|
|
f"refresh-marketplace hook must be wrapped in bash -c for Windows; got: {refresh!r}"
|
|
)
|
|
ends = _commands_for(cfg, "SessionEnd")
|
|
assert len(ends) == 1
|
|
assert "agnes push --quiet" in ends[0]
|
|
|
|
|
|
def test_install_idempotent(tmp_path):
|
|
install_claude_hooks(tmp_path)
|
|
install_claude_hooks(tmp_path)
|
|
cfg = _read_settings(tmp_path)
|
|
# Two SessionStart entries (pull + refresh-marketplace), one SessionEnd
|
|
# entry (push). Re-install must NOT duplicate them.
|
|
assert len(cfg["hooks"]["SessionStart"]) == 2
|
|
assert len(cfg["hooks"]["SessionEnd"]) == 1
|
|
|
|
|
|
def test_install_replaces_old_da_sync_entries(tmp_path):
|
|
"""Hook from a pre-rewrite workspace gets replaced cleanly — legacy
|
|
`da sync` entries are removed, both new agnes hooks land in their place."""
|
|
settings_path = tmp_path / ".claude" / "settings.json"
|
|
settings_path.parent.mkdir(parents=True)
|
|
settings_path.write_text(json.dumps({
|
|
"hooks": {
|
|
"SessionStart": [{"hooks": [{"type": "command", "command": "da sync --quiet"}]}],
|
|
"SessionEnd": [{"hooks": [{"type": "command", "command": "da sync --upload-only --quiet"}]}],
|
|
}
|
|
}))
|
|
install_claude_hooks(tmp_path)
|
|
cfg = _read_settings(tmp_path)
|
|
starts = _commands_for(cfg, "SessionStart")
|
|
assert len(starts) == 2
|
|
assert any("agnes pull" in c for c in starts)
|
|
assert any("agnes refresh-marketplace" in c for c in starts)
|
|
# Legacy command must be gone from BOTH starts.
|
|
assert not any("da sync" in c for c in starts)
|
|
|
|
|
|
def test_install_replaces_prior_single_pull_entry(tmp_path):
|
|
"""Workspaces bootstrapped by a CLI version that only installed a
|
|
single SessionStart entry (`agnes pull`, no refresh-marketplace) must
|
|
upgrade to the two-entry layout on the next install — not end up with
|
|
three entries (one old + two new)."""
|
|
settings_path = tmp_path / ".claude" / "settings.json"
|
|
settings_path.parent.mkdir(parents=True)
|
|
settings_path.write_text(json.dumps({
|
|
"hooks": {
|
|
"SessionStart": [
|
|
{"hooks": [{"type": "command", "command": "agnes pull --quiet 2>/dev/null || true"}]},
|
|
],
|
|
}
|
|
}))
|
|
install_claude_hooks(tmp_path)
|
|
cfg = _read_settings(tmp_path)
|
|
starts = _commands_for(cfg, "SessionStart")
|
|
assert len(starts) == 2
|
|
assert any("agnes pull" in c for c in starts)
|
|
assert any("agnes refresh-marketplace" in c for c in starts)
|
|
|
|
|
|
def test_install_replaces_v0_43_chained_self_upgrade_pull_entry(tmp_path):
|
|
"""Workspaces bootstrapped on v0.43.0 had a single SessionStart entry
|
|
chaining `agnes self-upgrade; agnes pull` in one shell line. Upgrading
|
|
those workspaces to v0.44.0+ must collapse that entry and re-install
|
|
the new two-entry layout — not stack the v0.44 entries on top of the
|
|
v0.43 chained one (which would re-run self-upgrade twice on every
|
|
session and leave the old format around forever).
|
|
"""
|
|
settings_path = tmp_path / ".claude" / "settings.json"
|
|
settings_path.parent.mkdir(parents=True)
|
|
settings_path.write_text(json.dumps({
|
|
"hooks": {
|
|
"SessionStart": [
|
|
{"hooks": [{"type": "command", "command": (
|
|
"agnes self-upgrade --quiet 2>/dev/null || true; "
|
|
"agnes pull --quiet 2>/dev/null || true"
|
|
)}]},
|
|
],
|
|
"SessionEnd": [
|
|
{"hooks": [{"type": "command", "command": "agnes push --quiet 2>/dev/null || true"}]},
|
|
],
|
|
}
|
|
}))
|
|
install_claude_hooks(tmp_path)
|
|
cfg = _read_settings(tmp_path)
|
|
starts = _commands_for(cfg, "SessionStart")
|
|
# Exactly two entries — the v0.43 chained line was replaced, not stacked.
|
|
assert len(starts) == 2, starts
|
|
chain = next(
|
|
(c for c in starts if "agnes self-upgrade" in c and "agnes pull" in c),
|
|
None,
|
|
)
|
|
assert chain is not None
|
|
assert any("agnes refresh-marketplace" in c for c in starts)
|
|
# SessionEnd untouched (single push entry).
|
|
ends = _commands_for(cfg, "SessionEnd")
|
|
assert len(ends) == 1
|
|
assert "agnes push --quiet" in ends[0]
|
|
|
|
|
|
def test_install_preserves_third_party_hooks(tmp_path):
|
|
settings_path = tmp_path / ".claude" / "settings.json"
|
|
settings_path.parent.mkdir(parents=True)
|
|
settings_path.write_text(json.dumps({
|
|
"hooks": {
|
|
"SessionStart": [{"hooks": [{"type": "command", "command": "echo hi from another tool"}]}],
|
|
"PreToolUse": [{"hooks": [{"type": "command", "command": "echo pre"}]}],
|
|
}
|
|
}))
|
|
install_claude_hooks(tmp_path)
|
|
cfg = _read_settings(tmp_path)
|
|
starts = _commands_for(cfg, "SessionStart")
|
|
# Third-party entry stays + both agnes entries get added.
|
|
assert len(starts) == 3
|
|
assert any("echo hi from another tool" in c for c in starts)
|
|
assert any("agnes pull" in c for c in starts)
|
|
assert any("agnes refresh-marketplace" in c for c in starts)
|
|
# Other event types untouched.
|
|
assert cfg["hooks"]["PreToolUse"][0]["hooks"][0]["command"] == "echo pre"
|
|
|
|
|
|
def test_install_handles_missing_settings_file(tmp_path):
|
|
install_claude_hooks(tmp_path)
|
|
assert (tmp_path / ".claude" / "settings.json").exists()
|
|
|
|
|
|
def test_install_handles_invalid_json(tmp_path, capsys):
|
|
settings_path = tmp_path / ".claude" / "settings.json"
|
|
settings_path.parent.mkdir(parents=True)
|
|
settings_path.write_text("not valid json {")
|
|
install_claude_hooks(tmp_path)
|
|
captured = capsys.readouterr()
|
|
assert "not valid JSON" in captured.err or "warning" in captured.err.lower()
|
|
|
|
|
|
def test_install_chains_self_upgrade_then_pull_in_one_entry(tmp_path):
|
|
install_claude_hooks(tmp_path)
|
|
cfg = _read_settings(tmp_path)
|
|
starts = _commands_for(cfg, "SessionStart")
|
|
# SessionStart has two entries: the chain (self-upgrade + pull) and
|
|
# the standalone refresh-marketplace. This test pins the chain
|
|
# invariant — order, both `|| true`-guarded — independent of the
|
|
# refresh-marketplace entry being present.
|
|
chain = next(
|
|
(c for c in starts if "agnes self-upgrade" in c and "agnes pull" in c),
|
|
None,
|
|
)
|
|
assert chain is not None, starts
|
|
assert "agnes self-upgrade --quiet" in chain
|
|
assert "agnes pull --quiet" in chain
|
|
# Order is encoded in the shell — self-upgrade must appear first
|
|
assert chain.index("agnes self-upgrade") < chain.index("agnes pull")
|
|
# Both segments carry || true so neither failure aborts the line
|
|
assert chain.count("|| true") >= 2
|
|
|
|
|
|
def test_install_idempotent_chained_entry(tmp_path):
|
|
install_claude_hooks(tmp_path)
|
|
install_claude_hooks(tmp_path)
|
|
cfg = _read_settings(tmp_path)
|
|
# Two SessionStart entries (chained self-upgrade+pull plus refresh-
|
|
# marketplace) — re-install must not duplicate either.
|
|
assert len(cfg["hooks"]["SessionStart"]) == 2
|
|
assert len(cfg["hooks"]["SessionEnd"]) == 1
|