Round-2 review (N1-N10): - N1 Token CLI keeps current `da auth token` location (not top-level) - N2 `da catalog --metrics --show <id>` decided in Components, dropped from Open questions - N3 `_install_claude_hooks` migrated to new `cli/lib/hooks.py` module - N4 Test sentinel `__nonexistent__` documented in fixtures - N5 `web_session` fixture uses real `POST /auth/token` with seeded password - N6 `AGNES_WORKSPACE.md` content asserts (PAT not leaked, placeholders substituted) added to clean-install integration test - N7 Admin UI legacy-strings banner concretized: `legacy_strings_detected` field + yellow banner in `/admin/workspace-prompt` editor - N8 `da metrics export/validate` relocate to `da admin metrics …` alongside `import` - N9 Bootstrap PAT verify endpoint switched from `/api/health` (unauth) to `/api/catalog/tables` (PAT-validating, matches `da auth import-token`) - N10 New `cli/lib/pull.py` and `cli/lib/hooks.py` modules inventoried Main-sync (rebased on 0.32.0 / #160): - Reconsidered: keep `da skills list / show` as analyst-side discovery (skill content was strengthened by #160 cost-guardrail/registry rails) - Bigger CLAUDE.md (repo-root) rewrite scope acknowledges new sections - `cli/error_render.py` (added in 0.32.0) reused by `da init` and `da pull` for consistent typed-error UX - Test fixtures piggyback on autouse `_reset_module_caches` from tests/conftest.py:50-82 (added in 0.32.0) |
||
|---|---|---|
| .. | ||
| plans | ||
| specs | ||