001e5ce40e
* feat(web): value-first /home reskin (CEO mock palette + pillars + first-session)
Restructures `/home` to lead with product value instead of install steps,
matching the CEO mock proposed for the homepage:
- New intro hero on top — eyebrow `Welcome, {{ display_name }}`, H1
`{{ instance_brand }} is your team's AI workspace`, lede framing the
product as an "AI Chief of Staff", two CTAs (`Set up in ~15 min →`
jumps to the wizard, `Just browse — no install needed` jumps to
`#look-around`), and a four-pillar row (Data packages · Plugins ·
Skills · Memory). Renders for both onboarded and not-onboarded users
so the value framing is consistent across visits.
- New `first-session` narrative — five-beat walkthrough (launch → pick
project → memory loads → ask → close) with mock terminal frames
carrying traffic-light dots, prompts, and dimmed system output.
- Setup wizard chrome — progress chip (`Step 1 of N · ~15 min ·
One-time · Reversible`), thin progress bar, and per-step number
badges on each `.install-block` so the wizard reads as bounded
instead of an open-ended scroll.
- Palette shift from blue to green/navy: `--hp-primary` aliases
`#2ea877` (mint), `--hp-hero-bg` is navy `#0f1b3a`, code panels stay
near-black `#0c1224` with warm-yellow `#ffd866` accents. The token
alias is reused so downstream rules pick up the new accent
automatically; instance theme overrides via
`config.theme_overrides()` still win.
- VS Code surface tile carries a `Recommended` pill; the existing
"Want to look around first?" section is renamed to `Explore your
workspace` and gets the `#look-around` anchor.
All test-pinned class names and IDs (`install-hero`, `install-block`,
`home-mock`, `self-mark-btn`, `setupClaudeBtn`, `offboard-strip`,
`home-getting-started`, `home-gs-item`, `home-overview`,
`home-usage`) preserved as structural anchors; new visual language
overlays via additional classes. Existing onboarded/not-onboarded
branching, `/api/me/onboarded` POST, status frame gating, post-CTA
modal, and OS-tab switching JS unchanged. Stray `~/FoundryAI`
comment swapped for `~/{{ workspace_dir }}` to honor the
vendor-agnostic OSS rule.
51 home tests pass without modification.
* fix(web): /home palette inversion — dark intro hero on top, light setup card below
Previous reskin commit kept the install-hero as a dark navy gradient and
rendered the new intro hero as a light surface — opposite of what the CEO
mock specifies. Playwright comparison vs `data/ceo_home.html` confirmed:
- CEO mock: dark navy hero at TOP (with white pillars on navy), LIGHT
white setup card BELOW with light step rows and dark code panels
inset.
- Previous: light intro hero on top, dark setup card below. Inverted.
This patch flips both:
- `.home-hero-intro` now: dark navy gradient `#0f1b3a → #1a2a5f`, green
radial glow in the corner, green eyebrow, white H1 (`accent` span
green), rgba-white lede, green pill primary CTA, translucent-white
secondary CTA, pillars row separated by hairline border-top with
green square-dot bullets in front of each pillar header.
- `.install-hero` and `.install-block` now: white surface card with
thin green accent strip across the top, light step rows split by
hairline borders, green-tinted step-number circles (`#e6f9f0` bg,
`#1f8a5e` ink), green progress chip + bar. Code panels
(`.install-cmd`) and terminal frames stay dark — they're the "type
this" surfaces.
- All previously-rgba-white descendants of `.install-hero`
(close button, eyebrow, h1, lead, links, code chips, OS tabs,
install notes, setup-CTA button, self-mark fallback, auto-detect
badge, terminal-howto disclosure) re-skinned for light surface.
All 12 home page tests still pass (no markup changes, only CSS).
* fix(web): /home parity polish — system font + mock sizes + blue info hint + gray step-num
After v2 palette flip, user comparison vs CEO mock surfaced three
remaining gaps in the wizard area:
- Font stack mismatch: Agnes inherits Inter via `style-custom.css`,
but the CEO mock uses the platform system stack (San Francisco on
macOS, Segoe UI on Windows). The rendered weight/letterforms read
noticeably different. `.home-mock` now declares
`-apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif`
for itself and all descendants, with the monospace stack reserved
for `code`/`kbd`/`pre`, `.install-cmd`, and `.terminal-body`.
- Step number badges were green-tinted; mock uses neutral gray
(`#f0f2f6` bg, `#4a5168` ink) — green is reserved for the "done"
state. Switched to `--hp-surface-dim` + `--hp-text-secondary`.
- "Don't have a terminal open?" disclosure was an amber/yellow
variant left over from the old dark-hero palette. Mock uses a
blue info-hint vocabulary (`--info-bg: #eef3ff`,
`--info-line: #4f7cf2`, `--info-ink: #1c3994`) with white kbd
chips. Added the info-* tokens to the `:root` block and re-skinned
`details.terminal-howto` (incl. summary, body, kbd) to match.
Step-body type sizes also brought in line with the mock spec —
`.install-block .label` (step h3 equivalent) is now 17px / 700 with
6px gap; `.install-note` body type is 14px / 1.55.
`--hp-info-bg / --hp-info-ink / --hp-info-line / --hp-warn-bg /
--hp-warn-ink / --hp-warn-line / --hp-surface-dim` added as
first-class tokens so future hint/warn callouts pick the same colors
without a duplicate vocabulary.
12/12 home tests pass.
* feat(web): centralize design tokens + reword /home wizard to 6 steps (CEO mock parity)
Two intertwined changes that touch both global design + /home structure:
GLOBAL TOKEN SHIFT (app/web/static/style-custom.css)
- `--primary` flipped from blue `#0073D1` to green `#2ea877` — same brand
alias the rest of the app referenced, so every page picks up the new
accent automatically. Old `--primary-dark` / `--primary-light` recolored
to match.
- New tokens added: `--brand-accent`, `--hero-bg`, `--hero-ink`,
`--surface-dim`, `--info-bg/ink/line`, `--warn-bg/ink/line`. Brings
the global vocabulary in line with the CEO mock's `:root` block so
callouts and hero surfaces don't have to invent local tokens.
- `--font-primary` switched from Inter-led stack to the system stack
(`-apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Inter",
system-ui, sans-serif`) so weight/letterforms render identically on
macOS (San Francisco) and Windows (Segoe UI) — matches the mock and
avoids a font-loading flash for analysts without Inter installed.
- Shadow tints re-cast in navy `rgba(15,27,58,...)`; focus ring uses
the new green `rgba(46,168,119,0.25)`.
- `.app-nav-link` font-size 13px → 14px, padding 6px 12px → 8px 14px,
hover bg → `--primary-light` (mint), color → `--primary-dark`.
`.app-nav-menu-item.is-active` re-tinted to the same green system.
- Sweep across 26 templates (style-custom.css + 25 template files)
replacing every hardcoded `#0073D1` / `#005BA3` / `#E6F3FC` /
`rgba(0,115,209,…)` / `rgba(0,86,163,…)` with token references or
the new green hexes — 175 occurrences total. Pages that styled their
own buttons / borders / shadows pick up the new brand color without
per-page overrides.
/HOME WIZARD: 6 STEPS PER MOCK (app/web/templates/home_not_onboarded.html)
- Step 1 reworded `Install Claude Code on your computer` + `~3 min`
subhead (mock copy).
- Step 2 renamed `Pick a folder for {{ instance_brand }}` (was
`create your workspace folder`) — same `mkdir` command, mock-aligned
framing.
- NEW Step 3 `Open a terminal inside that folder` — no shell command,
just the "you are standing in the right directory" reassurance with
a Finder/PowerShell/file-manager howto disclosure. Mirrors the CEO
mock's Step 3.
- Step 4 (was Step 3, gated by `home_automode.show`) renamed
`Launch Claude with auto-approve on`. Body copy lightly updated so
it references "the next step" instead of "Step 4".
- Step 5 (was Step 4) renamed `Get the install script and paste it
into Claude`. The setup-cta-lead now explicitly says
"pasting the script into Claude Code will install {{ instance_brand
}}…" so existing test assertions pinning the `install Agnes`
substring still match.
- NEW Step 6 `Optional: create a one-word shortcut for next time` —
prints an `echo 'alias {{workspace_dir|lower}}=…' >> ~/.zshrc`
one-liner for Unix and an `Add-Content $PROFILE …` equivalent for
Windows. OS tabs + copy buttons reuse the existing wizard chrome.
- Progress chip dynamic: `Step 1 of 6` when home_automode is on,
`Step 1 of 5` when off. Progress bar fill `100 // total_steps` so
the bar sits at 16-20 % on first paint.
- `.step-lede` token added for the new short body copy beneath each
step label (14.5px / ink-soft).
- `macOS / Linux / WSL` tab labels changed to `macOS / Linux` per
user instruction. Terminal-howto `WSL:` paragraph dropped; the
paste-shortcut hint now reads `(Linux)` instead of `(Linux/WSL)`.
Functional WSL handling in `connector_prompts.py` (it's a Linux
detection fallback, not user-facing label) preserved.
- `setup_instructions.py` Claude Code install hint:
`npm (Linux / WSL)` → `npm (Linux)`.
SURFACES — 4 CARDS PER MOCK
- Replaced the 3-tile `.home-usage-grid` with a 4-card grid:
- VS Code (Recommended) — `.surface-card.feature`, green ring,
DAILY USE eyebrow + 5-step numbered list + `Open VS Code setup
guide →` link to `/setup-advanced#vscode`.
- Terminal — QUICK ACCESS eyebrow + 4-step list.
- Claude Code (Desktop app) — CONNECT IT eyebrow + 4-step list.
- Cowork (claude.ai) — `.surface-card.incomplete`, warn-tinted
border + `Instructions needed` badge + a TODO callout describing
the missing content. The card is intentionally honest about the
gap rather than hiding it.
TEST UPDATES
- `test_web_home_page.py` negative onboarded-state assertions
rebased on the new step labels (6 entries instead of 4).
- `test_home_route_resolution.py` `test_home_renders_automode_block_by_default`
+ its `_when_env_off` counterpart now check the new
`Step 4 — Launch Claude with auto-approve on` label.
* fix(web): /home section content + layout — verbatim mock match
User comparison flagged several remaining gaps; this patch rewrites
the three lower sections of /home to match the CEO mock spec exactly:
FIRST-SESSION (5 beats)
- h2 28px / 700 / -.5px tracking (was 19px / 600).
- lede 18px ink-soft (was 13.5px secondary).
- `.session-walk` wrapper, 36px gap between beats (mock spec).
- `.session-step` grid 48px / 1fr, gap 22px — number circle on
the left, content on the right.
- `.session-num` 40 × 40 circle with SOLID GREEN bg (`--primary`)
and WHITE text + soft green shadow (was 28px mint pill w/
dark-green text).
- `.session-content h3` 18px / 600 (was 14.5px / 600).
- `.session-content > p` 15px.
- `.session-content .annotation` 13.5px ink-muted body type with
`strong` for highlighting (replaces the upper-case "WHAT'S
HAPPENING" eyebrow pattern that didn't match the mock).
- `.session-intro` callout card (white surface + mint icon block)
framing the "five beats" tagline.
- `.session-tldr` summary box (brand-light bg + brand-dark left
border) wrapping up the loop.
- Terminal frames re-skinned: `#0c1224` body / `#182241` bar /
real macOS traffic-light colors `#ff5f57` / `#febc2e` / `#28c840`.
- Terminal body 13px / 1.65 line-height with mock-spec class
vocabulary: `.you` (yellow input), `.ai-name` (brand bold),
`.path` (light blue), `.dim` (translucent code-ink), `.caret`
(blinking cursor).
- Five beats rewritten with mock's exact narrative flow (launch →
menu → pick → ask → close), vendor-agnostic project names
(`RevenueAnalysis`, `Onboarding`, etc.) replacing the customer-
specific `GRPN_*` examples in the mock. Templated `{{
instance_brand }}` / `{{ workspace_dir }}` / `{{ workspace_dir |
lower }}` (the shortcut alias) everywhere.
SURFACES (4 cards)
- The section is no longer wrapped in a white rectangle; the
`.home-usage` class loses its bg + border + padding (mock has the
cards directly on the page bg).
- h2 28px (was 22px). Eyebrow 12px / 1.5px tracking / brand-dark.
- `.surface-card.feature` (VS Code) now uses 2px green border +
vertical brand-light → white gradient (was 1px ring).
- `.surface-card.incomplete` (Cowork) uses 2px red border (`#e35e5e`)
+ vertical red-tint → white gradient (was yellow flat bg).
- `.surface-card .steps` panel: inner surface-dim bg + 8px radius
+ 13px font.
- `.surface-foot` top-border + ink-muted (mock spec).
- `.badge-warn` now a solid red box (`#e35e5e` bg + white ink + 4px
radius) instead of a yellow pill, matching the mock.
- Header layout fixed: the global absorbed `header { display: flex;
justify-content: space-between }` rule was making the h2 sit on
the right of the eyebrow; explicit `display: block` override on
`.home-mock section > header` puts the title on the LEFT under
the eyebrow as the mock has.
BROWSE — Explore your workspace
- Wrapped in `<section class="browse-section">` with proper
eyebrow + h2 + lede (was a bare `.section-label` div).
- `.browse-grid` 5-col grid (was responsive auto-fill, 4-card
layout). Skills tile added as a 5th card linking to
`/marketplace?type=skills`.
- `.browse-card` mock-spec: 22 20 padding, 28px icon, 15px title,
12.5px ink-muted desc, hover lifts -2px with brand border +
shadow-md.
Section wrappers (`.home-usage`, `.first-session`) no longer carry
the white card chrome — they sit directly on the page bg, matching
the mock. Only Getting Started + Overview keep their white cards.
GLOBAL eyebrow vocabulary (`.home-hero-intro .eyebrow`,
`.first-session > .eyebrow`, `.surfaces > header .eyebrow`,
`.browse-section .eyebrow`) all aligned to mock spec: 12px / 700 /
1.5px tracking / brand-dark color / 14px bottom margin.
Hero h1 bumped to 44px / 800 / -1px tracking (was 32px / 600).
51/51 home tests pass.
* fix(web): /home session-intro card + terminal-body verbatim mock match
User comparison flagged three remaining /home gaps; this patch
addresses each:
- `.session-intro` rule was missing — the "five beats" tagline
rendered as a bare line with no card chrome. Added the mock-
spec card: white surface, 14px radius, 20×24 padding, 1px
border + shadow-sm, with a 44×44 brand-light icon block on the
left.
- Beat 1 terminal-title was `~/{{ workspace_dir }} — zsh` (mock-
style shell-pwd format), but the user wants every terminal
frame across all 5 beats to read `claude — {{ instance_brand }}`.
Updated.
- Terminal-body line structure for beats 2-5 rewritten verbatim
from the CEO mock:
- `<span class="prompt">></span><span class="you">…</span>`
now has no space between the prompt and user input (mock
pattern: zero gap, the .prompt's `margin-right: 8px` provides
the visual separation).
- Beat 2 menu items use `<strong>[N]</strong>` numbering with
project entries on indented lines, each project name followed
by a `<span class="dim">(N ago)</span>` timestamp at a fixed
column — instead of my prior single-line concatenation.
- Beat 3 narrative split into 4 stanzas separated by blank lines
(matches mock): the "Switched to <strong>X</strong>" status,
then dim Loaded/Last-session lines, then a stand-alone "One
unprocessed input detected:" pair, then the "Want me to
process …" question. My prior version dim-wrapped the entire
block, which looked off.
- Beat 4 narrative split into headline summary + risks section
with <strong> heads + bullet lists separated by blank lines,
matching the mock's "Q1 close summary" / "Open risks" rhythm.
The Q1 question carries the mock's manual line-break + 2-
space continuation indent inside the `.you` span — without
that, terminal-body's `white-space: pre-wrap` would auto-wrap
awkwardly at a different column than the mock.
- Beat 5 exit narrative uses two separate dim lines + a
standalone `.ai-name` "See you next time." line, then prompt
+ caret. My prior version collapsed everything into one dim
block.
- Project names changed from customer-specific (`GRPN_*`) to
generic (RevenueAnalysis, WeeklyReview, Onboarding, OpsDb,
HRHandShake) so the OSS distribution stays vendor-agnostic
per CLAUDE.md.
- `Marketing plan` examples replaced with `Q1 close` so the
narrative stays plausible for an analyst audience.
12/12 home tests pass.
* fix(web): /home surfaces verbatim mock — VS Code thumb, Terminal expected-output, NEW badge
User comparison flagged three remaining surface-section gaps:
- VS Code surface card was rendering a generic "Screenshot pending"
placeholder; the mock has a labeled inline mockup
(`<a class="vscode-thumb">` w/ `.thumb-fallback`) showing the
recommended 4-pane layout (EXPLORER yellow, TERMINAL 1 purple,
TERMINAL 2 green, TERMINAL 3 orange) on a dark navy bg + a
"Recommended layout" caption pill. CSS `.vscode-thumb` block
added — uses gradient-strip backgrounds to draw the colored
panel bars without needing a base64 image.
- "Recommended" badge was a pill (999px radius) with
`--brand-accent` bg + navy text. Mock uses `.badge` instead of
`.recommend-pill` — solid `--primary` (brand-dark green) bg
with WHITE text and 4px radius. Replaced the class + CSS rule
so the badge reads as a tag, not a pill.
- Terminal surface card was missing the "What you should see"
subsection — mock has an `.expected-output` block showing a
sample of the welcome menu inside a dim dashed panel. Added the
block with the mock's exact rendered output (templated to
`{{ instance_brand }}` + generic project names instead of
customer-specific GRPN entries) plus the `.expected-output`
CSS (surface-dim bg + dashed border + `::before` "WHAT YOU
SHOULD SEE" eyebrow per mock spec).
Also addressed the explore-section feedback:
- Skills browse-card now carries the `new` class so it picks up
the `.browse-card.new::after` corner badge ("NEW", green bg,
white text, 10px / 700 / 0.5px tracking) per mock.
- Browse cards align same height via `align-self: stretch` (grid
default) + `flex-grow: 1` on `.browse-desc` so descriptions
fill remaining vertical space; previously the Skills tile sat
shorter because its desc text was longer than others'.
Structural HTML changes to all four surface cards: dropped the
inner `<div class="surface-card-head">` wrapper + `<p
class="surface-pitch">` class in favor of mock's flat layout
(`.what` + `.steps` + `.when-to-use`). `<ol class="surface-steps">`
replaced with `<div class="steps"><strong
class="steps-eyebrow">DAILY USE / QUICK ACCESS / CONNECT IT</strong>
<ol>...</ol></div>` so the eyebrow + numbered list share the
mock's tinted surface-dim panel.
12/12 home tests pass.
* fix(web): align /home setup walkthrough to design spec
- Setup-section header (eyebrow + heading + lede) floats above the
install hero; install card has no accent strip; step labels drop
`Step N —` prefix; closing strip is single flex row.
- VS Code surface card renders recommended-layout screenshot from
`/static/img/vscode-layout.png` with click-to-enlarge lightbox.
- Workspace install path cascades to `~/Desktop/{workspace_dir}` in
every step, surface card, first-session annotation, and shortcut.
- Step 1 verify text restores Enterprise — Finance and Legal option.
- Step 6 shortcut installs a shell function with arg forwarding
(`"$@"` unix / `@args` windows) and a user-facing Auto / YOLO
permission-mode toggle.
- Step 5 manual-fallback details inline on the CTA row; description
reads at step-lede size, not 13px chip.
- Setup-section heading no longer right-aligns (was inheriting
`header { display: flex; justify-content: space-between }` from
the legacy stylesheet; wrapper changed to `<div>`).
- Getting Started `<details>` block removed (duplicated links).
* test(web): align /home tests with restructured setup wizard
- Replace test_getting_started_card_renders_on_home with
test_setup_section_renders_for_not_onboarded — asserts the new
setup-section-header floats above the install hero and Getting
Started markup is absent (block removed in the prior commit).
- Update automode-block test to match labels without the
`Step N —` prefix.
- Update setup-CTA partial test to match the relabeled
"Copy install script to clipboard" button.
Drop orphaned CSS for `.home-getting-started`, `.home-gs-summary*`,
and `.home-gs-item` — selectors had no matching markup after the
Getting Started block was removed.
Also: Step 3 `pwd` expected-output uses an absolute path
(`/Users/yourname/Desktop/{workspace_dir}`) instead of the
tilde-prefixed form, matching what the command actually prints.
* fix(web): repaint home_onboarded + setup_advanced; align CTA label
- home_onboarded + setup_advanced still carried the retired blue
`#0056A3` as both `--hp-primary-dark` and the hero gradient
endpoint. Both reference `var(--primary-dark)` now so the green
palette cascades.
- setup_advanced YOLO snippet was the old `alias` form (no cd, no
arg forwarding). Replaced with the shell function variant from
/home Step 6 — drops into ~/Desktop/{workspace_dir} and forwards
"\$@" (unix) / @args (Windows).
- setup_advanced ~/{workspace_dir} path references cascaded to
~/Desktop/{workspace_dir} so install story matches /home.
- Dashboard's "Setup a new Claude Code" button label aligned to the
canonical "Copy install script to clipboard" — matches /home and
the new docstring in _claude_setup_cta.jinja, which now mandates
this label across consumers.
* fix(web): keep base brand blue; scope green palette to /home redesign
User noticed login + dashboard had turned green when the /home
redesign flipped --primary from blue (#0073D1) to green (#2ea877)
in commit 278f202e. The brand-wide flip went further than the
redesign needed — only /home, /home (onboarded), and /setup-advanced
intentionally use the green/navy spec; every other page (login,
dashboard, catalog, marketplace, admin, profile) was just inheriting
the green because --primary cascaded everywhere.
Revert the global brand colour to blue and lock the green into the
two outstanding redesign scopes:
- style-custom.css: --primary back to #0073D1, --primary-light back
to rgba(0,115,209,0.1), --primary-dark back to #005BA3,
--brand-accent back to a lighter blue.
- home_onboarded.html: .home-mock now sets --hp-primary,
--hp-primary-dark, --hp-primary-light to explicit green hex
(matching home_not_onboarded), so the hero stays green regardless
of the global brand.
- setup_advanced.html: same lock — .advanced-mock pins the green
palette in-scope.
Hero gradients on both pages now reference the local --hp-primary
chain (not the global --primary), so any future palette tweak inside
either scope cascades correctly without disturbing the rest of the app.
* refactor(web): hoist --hp-* into shared design-tokens.css (--ds-*)
PR 2 of the design-system extraction ladder. Pure mechanical rename
+ dedup; no visual diff on any rendered page (verified on /home,
/dashboard).
- New app/web/static/css/design-tokens.css declares the full token
set on :root: brand surface (green primary, primary-dark, mint
light, brand-accent), hero (navy bg + ink), code-panel (near-black
bg + cool ink + warm-yellow), light surfaces (bg/surface/border),
text (primary/secondary/muted), orange accent, info + warn
callout vocabularies, navy-tinted elevation shadows, system font
stack + mono.
- base.html loads it alongside style-custom.css so the tokens are
globally available.
- Rename --hp-* -> --ds-* in home_not_onboarded (313 refs),
home_onboarded (15), setup_advanced (39). 367 token references
pointed at one of three local blocks; now all point at the
global :root.
- Drop the three local token blocks. Each scope class
(.home-mock / .advanced-mock) only keeps its base ink + font-size
+ line-height rules.
The legacy --primary family stays canonical for the blue base
brand — login, dashboard, catalog, marketplace, admin still read
blue. The design system is opt-in via the scope class.
* refactor(web): extract shared components.css; migrate /home markup
PR 3 of the design-system extraction ladder. First batch of
reusable components lifted out of home_not_onboarded.html into a
new shared stylesheet; markup migrated to consume them.
- New app/web/static/css/components.css with five components, all
reusable on any page that loads design-tokens.css:
.callout-rec — amber lightbulb recommendation box
.callout-hint — blue info hint box
.code-output — "WHAT YOU SHOULD SEE" terminal output block
.lightbox — full-bleed image enlarge overlay
.setup-section-header — wizard header (eyebrow + h2 + lede)
- base.html loads components.css after design-tokens.css.
- home_not_onboarded.html markup renamed:
class="rec" -> class="callout-rec"
class="hint" -> class="callout-hint"
class="expected-output" -> class="code-output"
- Local CSS rules removed from home_not_onboarded.html for each of
the extracted components — ~150 lines down to 5-line "extracted to
components.css" comments. The bespoke wizard-specific styles
(.install-cmd, .os-tabs, .mode-tabs, .terminal-frame) stay
template-local for now since they only have one consumer.
Visual regression check: /home install hero renders the amber rec
callout, blue hint callout, dashed code-output block, green section
header, and click-to-enlarge VS Code thumb identically to the
pre-extraction render. 43 home tests pass.
* fix(web): unify page-headers — activity-center full-width, marketplace shares box
- /activity-center audit-log hero rendered as half-width because the
_page_hero include was inside <header class="obs-topbar">, a flex
row that pinned the time-range + auto-refresh controls next to it.
The hero is now a sibling rendered before the <header>, so it
spans the full container width like every other admin page; the
controls keep their flex row underneath.
- Marketplace hero unified with .page-header--hero. Markup is now
<section class="page-header page-header--hero mp-hero"> so the
shared box drives padding/radius/gradient/max-width/shadow; the
.mp-hero override block only carries the right-anchored cover
image and the rules for the search row + scope checkboxes (which
the canonical hero doesn't have). Inner text uses the canonical
.page-header__eyebrow / __title / __subtitle classes.
- .page-header--hero shadow tint now follows the brand blue
(rgba(0, 115, 209, 0.2)) instead of the leftover green from the
prior palette flip; same depth highlight everywhere the gradient
is blue.
* fix(web): unify remaining page heroes — admin, profile, install, store, stack
Sweep across pages that carried bespoke gradient hero markup so
every page-hero shares the canonical `.page-header--hero`
dimensions (padding 28/32/24, border-radius 14, max-width
var(--width-app), navy-tinted shadow, gradient with --primary →
--primary-dark). Inner text uses the .page-header__eyebrow /
__title / __subtitle classes so typography matches across the app.
- admin_tables: migrated to _page_hero.html include.
- admin_tokens: kept .tokens-hero wrapper for the counts-chip row
but added the canonical class on the same element; stripped
duplicate gradient + padding + typography rules.
- install: same pattern (kept hero-meta pill row).
- profile: migrated to _page_hero.html include.
- store_upload: kept .upload-hero wrapper for the .meta chip row;
composite class with the canonical hero.
- setup_advanced: .advanced-mock .ad-hero now matches canonical
dimensions; green palette retained via --ds-primary/dark.
- stack_card.css: .stack-hero (catalog + corporate-memory search
hero) uses canonical gradient + padding + max-width.
The detail-page heroes (marketplace_plugin_detail,
marketplace_item_detail, catalog_*_detail, store_edit,
admin_group_detail, admin_store_submission_detail) stay bespoke
for now — they're rich detail headers with photos, badges, install
actions; converting them would lose contract context. Same applies
to dashboard.html env-setup-cta (it's a CTA card, not a page hero).
* fix(web): canonicalise .container — single page shell every page inherits
Previously each admin page set its own `.container:has(.<page>)
{max-width: none}` + `.<page>-page {max-width: 1400px}` override,
and per-page hero markup either nested inside flex toolbars (which
pinned the hero next to filter controls and squeezed it half-width)
or self-constrained with a different max-width than the page. /home,
/dashboard, /marketplace, and /admin/* ended up at different widths
with different nav-to-hero gaps.
- style-custom.css `.container` now carries the canonical 1280px
max-width + `16px 32px 48px` padding so every page inherits the
same nav-to-hero gap and side gutters. `.container > main` is
margin/padding 0 so the container is the sole owner of gutters.
- `.page-header--hero` drops its self-constraining max-width and
auto-centering margin — the container provides the width, so the
hero sits flush with the table/toolbar below it.
- `.stack-hero` (catalog + corporate-memory) and `.advanced-mock
.ad-hero` (/setup-advanced) follow the same pattern: container
owns the width.
- Per-page max-width overrides stripped from admin_users,
admin_access, admin_groups, admin_marketplaces, admin_welcome,
admin_workspace_prompt.
- _page_hero include extracted from inside flex toolbars on
admin_users, admin_access, admin_groups, admin_marketplaces,
admin_server_config, admin_welcome, admin_workspace_prompt,
admin_sessions, admin_session_detail, admin_usage,
activity_center. The toolbar (`.users-toolbar`, `.gp-toolbar`,
etc.) keeps only the filter + action controls; hero renders
before it as a sibling.
- _page_chrome.html trimmed to just the page-background tint for
the redesign scopes; the duplicate `.container` rules it carried
are now redundant.
Verified: /home, /admin/marketplaces, /admin/users all render
container width 1280px with hero top at 88px (16px below the
72px-tall sticky nav). Same spacing as /home design spec.
* fix(web): admin_tables + admin_corporate_memory inherit canonical .container
Both pages were overriding `{% block layout %}` from base.html,
which bypasses the canonical `.container` wrapper. Result: hero
span the full viewport (1596px on a wide screen) while the inner
content sat at a narrower max-width — hero and content didn't
align, and the nav-to-hero gap differed from every other admin
page.
Switched both templates to `{% block content %}` so they render
inside the canonical `.container` from base.html — same path as
admin_groups, admin_users, admin_marketplaces, etc.
- admin_tables: dropped local `.page-title { max-width: 1600px }`
+ `.content { max-width: 1600px }` overrides (kept typography +
inner gutter rules) and the mobile padding overrides that paired
with them. Container now owns the gutters.
- admin_corporate_memory: only the block keyword needed changing;
the template already had a clean inner structure (no max-width
override on `.container-memory`).
Verified on /admin/tables and /admin/corporate-memory:
- .container width 1280, padding 16/32/48
- Hero top 88 (nav 72 + container padding-top 16)
- Hero + content both 1216px wide, both at left 190 — perfect
alignment with /admin/groups.
* fix(web): drop .page-shell padding override + admin_tables stale :root
Two regressions discovered after the canonical-container unification:
1. `.container:has(.page-shell)` still set `padding: 28px 32px 48px`
while the canonical `.container` had moved to `16px 32px 48px`.
Every page-shell consumer (/admin/sessions, /admin/sessions/<id>,
/admin/usage, /marketplace, /dashboard, marketplace detail pages,
/me/activity, /store/*, /admin/store-submissions) was rendering
with a 28px nav-to-hero gap while /admin/users + /admin/groups
rendered with 16px. Same width, mismatched vertical rhythm.
The opt-in rule is now a no-op marker: canonical container
already provides 1280px + 16/32/48 + main margin/padding 0.
2. admin_tables.html had a stale `<style>` block that re-declared
`:root { --primary: var(--primary); ... }`. The self-referential
token resolved to empty, collapsing the page-header hero's
`linear-gradient(135deg, var(--primary), var(--primary-dark))`
to no background — the hero appeared as a pale ghost without
colour. The entire shadow `:root` block was a stale copy of the
design tokens that style-custom.css already provides. Dropped
it; tokens now resolve from the global `:root`.
After both fixes /admin/sessions, /admin/tables, and every other
page-shell consumer match /admin/groups exactly: container 1280px,
container padding-top 16px, hero at top 88px / left 190px / width
1216px.
* fix(web): drop /admin/tokens .tokens-page width + padding override
`.tokens-page` carried its own `max-width: 1280px; margin: 0 auto;
padding: 28px 8px 48px` block — the canonical `.container` already
provides width + 16/32/48 padding, so the nested wrapper was
adding 28px on top of the container's 16px (= 44px nav-to-hero
gap, vs 16px on every other admin page) and shrinking the hero
sideways by 8px on each side (1200px vs the canonical 1216px).
After: container owns the layout; `.tokens-page` is just a
font-family scope. /admin/tokens hero now sits at top 88, left 190,
width 1216 — same numbers as /admin/groups / /admin/users.
* fix(web): hero links readable on blue; /admin/access Groups link href
- New `.page-header--hero a` rule in style-custom.css forces any
anchor inside a gradient hero to render white + underlined so
links stay readable on the blue background. Previously links
inherited the global `var(--primary)` blue, which disappeared
on top of the matching blue gradient. No per-page class needed —
drop a plain `<a>` in any hero subtitle and it just works.
- /admin/access hero subtitle was Jinja-passing the inline link
with HTML-entity-encoded quotes (`href="..."`). The
entities decoded to literal `"` characters inside the rendered
href, producing `/admin/%22/admin/groups%22` — a 404. Switched
the `set` to a block-set (`{% set page_hero_subtitle %}...{% endset %}`)
so the inline `<a href="/admin/groups">Groups</a>` survives
unescaped through `_page_hero.html`. Also stripped the now-redundant
inline `style="color:#fff;text-decoration:underline;"` — the new
shared rule handles it.
* fix(web): /dashboard top padding matches every other page
`.main` on /dashboard had `padding: 28px 32px 48px` while every
other page now uses `16px 32px 48px` via the canonical
`.container`. Dashboard bypasses `.container` (overrides
base.html's `layout` block to render a full-width `<main>`
directly), so the padding lives on `.main` itself — bumped the
top to 16px to match.
After: first child top = 88, left = 190, width = 1216 — same
numbers as /admin/groups / /admin/users / /admin/marketplaces.
* fix(web): green eyebrow + white title on .page-header--hero (matches /home)
`.page-header--hero .page-header__eyebrow` was faint white
(rgba(255,255,255,0.75)) — readable but unbranded against the blue
gradient. Changed to `var(--ds-brand-accent)` (mint green #54d3a0)
so every page hero pairs a green eyebrow with white title +
subtitle, echoing /home's setup-section header (green eyebrow,
dark heading combo). One CSS rule applies everywhere — no
per-page styling needed.
Also bumped the eyebrow to font-weight 700 / letter-spacing 1.2px
so the green stands out cleanly against the gradient.
* fix(web): page-header--hero + stack-hero use /home navy gradient
`.page-header--hero` and `.stack-hero` were on the brand-blue
gradient (`var(--primary)` → `var(--primary-dark)`) while
/home's hero (`.home-hero-intro`) sits on the deeper navy
gradient (`#0f1b3a` → `#1a2a5f`). Every other page-hero now
uses that same navy gradient so /home, /marketplace, /catalog,
/corporate-memory, /admin/*, /profile, /install, /dashboard,
/setup-advanced share one brand surface. Shadow tint adjusted
to the navy depth (rgba(15, 27, 58, 0.22)).
Brand blue stays the link/CTA colour everywhere else; only the
hero box itself is navy.
* fix(web): primary buttons green; marketplace tabs navy translucent
Two parity tweaks pulling the rest of the app toward /home's
visual language.
- `.btn-primary` (both rules in style-custom.css) now uses
`var(--ds-primary)` / `var(--ds-primary-dark)` green fill,
matching the "Copy install script to clipboard" button on
/home. Brand-blue `--primary` still drives link colour and the
accent surface; only the filled button background flipped to
green. Every page with a `.btn-primary` (admin "+Add user",
"+Add marketplace", catalog, marketplace actions, dashboard,
modals) now reads as the same "do it" affordance.
- `.mp-tabs` (Curated Marketplace / Flea Market / My Stack tab
group) now sits on the navy `--ds-hero-bg` with translucent
white pills (rgba(255,255,255,0.10) inactive, 0.18 active) —
same translucent-white-on-navy treatment as the "Just browse —
no install needed" pill on /home. Icons render as soft white;
per-tab colour-coding dropped in favour of the unified surface.
* fix(web): catalog/memory tabs + empty-state CTA + admin action buttons
Bring /catalog and /memory in line with /home + /marketplace:
- `.stack-tabs` (Browse / My Stack / Recipes on /catalog,
Browse / My Stack on /memory) now uses the navy `--ds-hero-bg`
container with translucent-white-on-navy pills, mirroring the
`.mp-tabs` treatment and /home's "Just browse — no install
needed" CTA pill. Per-tab icon colour-coding dropped — icons
render as soft white on the navy fill.
- `.stack-tabs-row__actions .btn` (right-slot "+New Recipe",
"+New Data Package" admin CTAs) now uses green primary fill
(`--ds-primary`), matching `.btn-primary` and /home's
"Copy install script to clipboard" button.
- `.stack-empty .cta a` (empty-state action button — the
"Open /admin/tables →" CTA on /catalog and equivalent on
/memory) flipped from blue `--primary` to green `--ds-primary`
so the colour aligns with every other primary button in the app.
* fix(web): marketplace Search button green (--ds-primary) matching other CTAs
* fix(web): unify Search button + admin-action button across browse pages
- Added Search button (`<button class="stack-hero__search-btn">`)
to /catalog and /memory heroes — same green pill as /marketplace.
Wired to the existing live-filter pipeline (button click runs
`applyFilters()` and refocuses the input). All three browse pages
now wear the identical search bar UI.
- `.stack-hero__search-btn` shares `--ds-primary` fill with
`.mp-hero .search-btn`.
- `.mp-actions .btn` ("Submit a skill or plugin" CTA on /marketplace)
flipped from the legacy blue-outline to the same green primary
fill + dimensions (`display: inline-flex; line-height: 1;
padding: 9px 16px; gap: 6px`) as `.stack-tabs-row__actions .btn`
on /catalog and /memory. All three right-slot action buttons
render at identical height now.
- `.stack-tabs-row__actions .btn` got `inline-flex` + `line-height: 1`
+ `gap: 6px` so a `<button class="btn">` and a `<a class="btn">`
both render at exactly 33px high — the embedded
`.admin-only-hint` chip no longer pushes one variant taller
than the other.
* fix(web): marketplace guide CTAs green (fastpath + primary); drop flea purple
* fix(web): dashboard CTA hero on navy; readable <code> chips in hero
- `.env-setup-cta` on /dashboard ("Set up a new Claude Code"
card) flipped from the brand-blue gradient + green-tinted shadow
to the canonical navy gradient (`--ds-hero-bg` → `#1a2a5f`) with
navy-tinted shadow + 14px radius + 28/32/24 padding, matching
`.page-header--hero` and /home's `.home-hero-intro`. Dashboard's
top CTA now sits on the same brand surface as every other hero.
- Added `.page-header--hero code` rule — translucent white pill +
warm-yellow ink (#ffd866) so `<code>` chips embedded in hero
subtitles read as code samples against the navy gradient. The
global `code` rule sets `color: var(--text-primary)` (dark),
which turned in-hero chips into invisible dark-on-white-on-navy
ghosts (e.g. the `-by-dev` suffix on /store/new).
- /store/new's `.page-header__subtitle code` dropped its inline
style override — the shared rule handles it now.
* feat(web): two-theme switching via data-theme + admin toggle
Introduces a theme system that flips the entire UI palette between
"navy" (current design, default) and "blue" (pre-redesign palette)
via a single `<html data-theme="...">` attribute. Page markup, class
names, and component styles don't change — only the `--ds-*` token
values flip.
Backend
- New `app/instance_config.py::get_instance_theme()` resolves the
active theme from `AGNES_INSTANCE_THEME` env > `instance.theme`
in instance.yaml > default "navy". Unrecognised values clamp to
"navy" so a typo doesn't break the page.
- `app/web/router.py::_build_context` injects `instance_theme`
alongside `instance_brand` etc. so every template inherits it.
- `app/web/templates/base.html` renders
`<html lang="en" data-theme="{{ instance_theme | default('navy') }}">`.
CSS
- `app/web/static/css/design-tokens.css` adds two new tokens to
the default `:root` set: `--ds-hero-shadow` (drop-shadow tint
on hero boxes) and `--ds-hero-eyebrow` (eyebrow accent colour).
Plus a `:root[data-theme="blue"]` override block that flips
seven tokens: `--ds-primary`, `--ds-primary-dark`,
`--ds-primary-light`, `--ds-brand-accent`, `--ds-hero-bg`,
`--ds-hero-bg-deep`, `--ds-hero-shadow`, `--ds-hero-eyebrow`.
The blue theme aliases the brand surface tokens back to the
legacy `--primary` family.
- `.page-header--hero`, `.stack-hero`, `.env-setup-cta`,
`.home-mock .home-hero-intro` now reference the new
`--ds-hero-shadow` and `--ds-hero-bg-deep` tokens instead of
hard-coding `rgba(15, 27, 58, 0.22)` and `#1a2a5f` — gradient +
shadow now flip with the theme.
- `.page-header--hero .page-header__eyebrow` uses
`var(--ds-hero-eyebrow)` so the eyebrow goes mint-green on
navy and translucent-white on blue (mint on blue reads poorly).
Admin
- `app/api/admin.py::_KNOWN_FIELDS["instance"]` now registers a
`theme` field of kind `select` with options `["navy", "blue"]`
and a `hint` explaining the trade-off. The existing
/admin/server-config UI auto-renders a select for this — no
template changes needed.
Defaults
- Default value is "navy" so existing instances see no visual
change. Admins flip to "blue" via /admin/server-config to
restore the pre-redesign look.
Restart note: uvicorn must reload to pick up the Python changes
(new getter, new template-context key, new known-field). CSS
changes hot-reload via browser refresh.
* fix(web): blue theme — home hero eyebrow + CTA contrast
`.home-hero-intro .eyebrow` and `.btn-intro-primary` referenced
`--ds-brand-accent` directly, which on the blue theme resolves to
the lighter brand-accent blue (#4F9DEB). Result: light-blue eyebrow
on the blue gradient ("WELCOME, ADMIN" barely readable) and a
light-blue button with darker-blue text ("Set up in ~15 min")
that all sat in the same hue range.
Introduces three new theme-aware tokens:
- `--ds-hero-eyebrow` already existed; blue theme bumped opacity
to 0.92 so the eyebrow reads as full white.
- `--ds-hero-cta-bg` + `--ds-hero-cta-fg` + `--ds-hero-cta-bg-hover`
flip the primary hero CTA: mint-green on navy (default), white-
on-blue under `data-theme="blue"`.
`.home-hero-intro .eyebrow` now uses `--ds-hero-eyebrow` (mint on
navy / white on blue) and `.btn-intro-primary` uses the CTA token
trio.
Recommended palette on blue theme:
- Eyebrow: white at 92% opacity (clear on the blue gradient).
- Primary CTA pill: white background, brand-blue dark text
(`--primary-dark` = #005BA3) for AAA-level contrast.
- Secondary CTA: translucent white pill (unchanged).
* fix(web): blue theme — callout-hint info bg/border/ink re-tinted to brand blue (was indigo, clashed with brand-blue hero)
1462 lines
67 KiB
HTML
1462 lines
67 KiB
HTML
{% extends "base.html" %}
|
||
{% block title %}Server config — {{ config.INSTANCE_NAME }}{% endblock %}
|
||
|
||
{% block content %}
|
||
{# Server configuration editor — instance.yaml fields grouped by section.
|
||
|
||
Page-shell only: GET /api/admin/server-config feeds the form (with
|
||
secrets redacted), POST /api/admin/server-config saves a section. The
|
||
"danger-zone" sections (auth, server) get a confirmation dialog before
|
||
the request is sent. Saves trigger the restart banner — hot-reload is
|
||
out of scope for #91. #}
|
||
<style>
|
||
.container:has(.cfg-page) { max-width: none; padding: 24px 16px; }
|
||
.cfg-page { max-width: 1100px; margin: 0 auto; padding: 0; }
|
||
.cfg-toolbar {
|
||
display: flex; justify-content: space-between; align-items: center;
|
||
gap: 16px; margin-bottom: 16px; flex-wrap: wrap;
|
||
}
|
||
|
||
.cfg-banner {
|
||
padding: 12px 16px; border-radius: 8px;
|
||
background: #fffbeb; border: 1px solid #fcd34d; color: #92400e;
|
||
font-size: 13px; margin-bottom: 16px; display: none;
|
||
}
|
||
.cfg-banner.is-visible { display: block; }
|
||
.cfg-banner.success { background: #ecfdf5; border-color: #34d399; color: #065f46; }
|
||
.cfg-banner.error { background: #fef2f2; border-color: #fca5a5; color: #991b1b; }
|
||
|
||
.cfg-section {
|
||
background: var(--surface, #fff);
|
||
border: 1px solid var(--border, #e5e7eb);
|
||
border-radius: 12px;
|
||
margin-bottom: 16px;
|
||
overflow: hidden;
|
||
}
|
||
.cfg-section.is-danger { border-color: #fca5a5; }
|
||
.cfg-section header {
|
||
padding: 14px 18px;
|
||
background: var(--border-light, #f9fafb);
|
||
border-bottom: 1px solid var(--border, #e5e7eb);
|
||
display: flex; align-items: center; justify-content: space-between;
|
||
gap: 12px;
|
||
}
|
||
.cfg-section.is-danger header { background: #fef2f2; }
|
||
.cfg-section h3 {
|
||
margin: 0; font-size: 15px; font-weight: 600;
|
||
}
|
||
.cfg-section h3 .danger-pill {
|
||
display: inline-block; margin-left: 10px;
|
||
padding: 2px 8px; border-radius: 999px;
|
||
background: #b91c1c; color: #fff;
|
||
font-size: 10px; font-weight: 700; text-transform: uppercase;
|
||
letter-spacing: 0.6px; vertical-align: 2px;
|
||
}
|
||
.cfg-section .section-help {
|
||
font-size: 12px; color: var(--text-secondary, #6b7280); margin-top: 4px;
|
||
}
|
||
.cfg-section .section-body { padding: 18px; }
|
||
.cfg-section .section-actions {
|
||
padding: 12px 18px;
|
||
background: var(--border-light, #fafafa);
|
||
border-top: 1px solid var(--border, #e5e7eb);
|
||
display: flex; justify-content: flex-end; gap: 8px;
|
||
}
|
||
|
||
.cfg-field { display: grid; grid-template-columns: 220px 1fr; gap: 12px; align-items: start; margin-bottom: 14px; }
|
||
.cfg-field:last-child { margin-bottom: 0; }
|
||
.cfg-field label { font-size: 13px; color: var(--text-primary, #111827); font-weight: 500; padding-top: 8px; }
|
||
.cfg-field .field-help { font-size: 11px; color: var(--text-secondary, #6b7280); margin-top: 4px; }
|
||
.cfg-field input[type="text"],
|
||
.cfg-field input[type="password"],
|
||
.cfg-field input[type="email"],
|
||
.cfg-field input[type="number"],
|
||
.cfg-field input[type="url"],
|
||
.cfg-field select,
|
||
.cfg-field textarea {
|
||
width: 100%; padding: 8px 12px;
|
||
border: 1px solid var(--border, #e5e7eb); border-radius: 8px;
|
||
font-size: 13px; box-sizing: border-box;
|
||
background: var(--surface, #fff); color: var(--text-primary, #111827);
|
||
font-family: inherit;
|
||
}
|
||
.cfg-field textarea { resize: vertical; min-height: 80px; font-family: var(--font-mono, ui-monospace, "SF Mono", Menlo, monospace); font-size: 12px; }
|
||
.cfg-field input:focus, .cfg-field select:focus, .cfg-field textarea:focus {
|
||
outline: 2px solid var(--primary, #6366f1); outline-offset: -1px;
|
||
}
|
||
.cfg-field input.is-secret { font-family: var(--font-mono, ui-monospace, monospace); }
|
||
.cfg-field .secret-pill {
|
||
display: inline-block; margin-left: 8px;
|
||
padding: 1px 6px; border-radius: 4px;
|
||
background: #f3f4f6; color: #6b7280;
|
||
font-size: 10px; text-transform: uppercase; letter-spacing: 0.5px;
|
||
}
|
||
|
||
.cfg-btn {
|
||
padding: 8px 16px; border-radius: 8px; font-size: 13px; font-weight: 500;
|
||
border: 1px solid var(--border, #e5e7eb); background: var(--surface, #fff);
|
||
cursor: pointer; transition: all 0.15s;
|
||
}
|
||
.cfg-btn:hover { background: var(--border-light, #f9fafb); }
|
||
.cfg-btn.primary { background: var(--primary, #6366f1); color: #fff; border-color: var(--primary, #6366f1); }
|
||
.cfg-btn.primary:hover { filter: brightness(1.05); }
|
||
.cfg-btn.danger { background: #dc2626; color: #fff; border-color: #dc2626; }
|
||
.cfg-btn.danger:hover { filter: brightness(1.05); }
|
||
.cfg-btn:disabled { opacity: 0.5; cursor: not-allowed; }
|
||
|
||
.cfg-loading { padding: 32px 16px; text-align: center; color: var(--text-secondary, #6b7280); font-size: 13px; }
|
||
|
||
/* Known-but-unset fields (sourced from the known_fields registry) — render
|
||
dashed and de-emphasised so the operator sees "this is a knob you can
|
||
turn" without confusing it with a populated value. */
|
||
.cfg-field.is-unset label { color: var(--text-secondary, #9ca3af); }
|
||
.cfg-field.is-unset input[type="text"],
|
||
.cfg-field.is-unset input[type="password"],
|
||
.cfg-field.is-unset input[type="number"],
|
||
.cfg-field.is-unset select,
|
||
.cfg-field.is-unset textarea {
|
||
border-style: dashed;
|
||
background: var(--background, #fafafa);
|
||
}
|
||
.cfg-field.is-unset .field-help { font-style: italic; }
|
||
.cfg-divider {
|
||
border: 0;
|
||
border-top: 1px dashed var(--border, #e5e7eb);
|
||
margin: 12px 0;
|
||
}
|
||
.cfg-divider-label {
|
||
display: block;
|
||
font-size: 11px;
|
||
color: var(--text-secondary, #9ca3af);
|
||
margin-bottom: 8px;
|
||
text-transform: uppercase;
|
||
letter-spacing: 0.05em;
|
||
}
|
||
|
||
/* Confirmation modal — danger-zone gate */
|
||
.modal-backdrop {
|
||
position: fixed; inset: 0; background: rgba(15, 23, 42, 0.55);
|
||
display: none; align-items: center; justify-content: center; z-index: 1000;
|
||
padding: 16px;
|
||
}
|
||
.modal-backdrop.is-open { display: flex; }
|
||
.modal-card {
|
||
background: var(--surface, #fff); border-radius: 12px;
|
||
padding: 24px; width: 100%; max-width: 520px;
|
||
box-shadow: 0 20px 60px rgba(0, 0, 0, 0.25);
|
||
}
|
||
.modal-card h3 { margin: 0 0 6px; font-size: 17px; font-weight: 600; }
|
||
.modal-card p.sub { margin: 0 0 12px; font-size: 13px; color: var(--text-secondary, #6b7280); }
|
||
.modal-card .diff-list {
|
||
background: var(--border-light, #f9fafb); border-radius: 8px;
|
||
padding: 10px 14px; font-family: var(--font-mono, ui-monospace, monospace);
|
||
font-size: 12px; max-height: 240px; overflow: auto; margin: 12px 0;
|
||
}
|
||
.modal-card .diff-row { padding: 4px 0; border-bottom: 1px dashed var(--border, #e5e7eb); }
|
||
.modal-card .diff-row:last-child { border-bottom: none; }
|
||
.modal-card .diff-row .path { color: #b91c1c; font-weight: 600; }
|
||
.modal-actions { display: flex; gap: 8px; justify-content: flex-end; margin-top: 18px; }
|
||
</style>
|
||
|
||
<div class="cfg-page" data-page="server-config">
|
||
{% set page_hero_eyebrow = "Server" %}
|
||
|
||
{% set page_hero_title = "Server configuration" %}
|
||
|
||
{% set page_hero_subtitle = "Edits land in <code style="color:#fff;background:rgba(255,255,255,0.15);padding:1px 6px;border-radius:4px">instance.yaml</code>. Save triggers an app restart (~10s downtime). Secret values are masked here — re-enter them to change." %}
|
||
|
||
{% include "_page_hero.html" %}
|
||
|
||
<div class="cfg-toolbar">
|
||
<div>
|
||
</div>
|
||
</div>
|
||
|
||
<div id="cfg-banner" class="cfg-banner" role="status" aria-live="polite"></div>
|
||
|
||
<div id="cfg-loading" class="cfg-loading">Loading current configuration…</div>
|
||
<div id="cfg-sections" hidden></div>
|
||
|
||
<!--
|
||
Initial Workspace Template — admin-configurable per-instance override
|
||
for `agnes init` analyst workspace. Lives on this page but is NOT part
|
||
of the generic instance.yaml form save (data routes through dedicated
|
||
/api/admin/initial-workspace endpoints because of PAT handling).
|
||
See docs/initial-workspace-override.md for the full responsibility-
|
||
transfer contract.
|
||
|
||
Visual shape matches the other .cfg-section blocks on this page
|
||
(header / section-body / section-actions) so the page reads as one
|
||
cohesive panel.
|
||
-->
|
||
<section class="cfg-section" id="iw-section">
|
||
<header>
|
||
<div>
|
||
<h3>Initial Workspace Template</h3>
|
||
<div class="section-help">
|
||
Optional. Replace the default <code>agnes init</code> workspace
|
||
skeleton with content from your own Git repo. When set, Agnes
|
||
ships <strong>none</strong> of its own files — your repo is
|
||
authoritative for CLAUDE.md, hooks, slash commands, settings,
|
||
and folder layout. See <code>docs/initial-workspace-override.md</code>
|
||
for the full responsibility-transfer contract.
|
||
</div>
|
||
</div>
|
||
</header>
|
||
<div class="section-body" id="iw-body">
|
||
<div id="iw-loading" class="cfg-loading">Loading…</div>
|
||
</div>
|
||
<div class="section-actions" id="iw-actions" hidden></div>
|
||
</section>
|
||
</div>
|
||
|
||
<!-- Initial Workspace Template — register / edit modal.
|
||
|
||
Form fields use a dedicated stacked layout (.iw-form-field) — NOT the
|
||
page-level .cfg-field grid (which is 220px label / 1fr value, designed
|
||
for the wide section body, not a 480px modal). Inside the modal,
|
||
stacking label-above-input is the standard for narrow forms. -->
|
||
<div class="modal-backdrop" id="iw-modal" role="dialog" aria-modal="true" aria-labelledby="iw-modal-title">
|
||
<style>
|
||
.iw-form-field { display: block; margin-bottom: 14px; }
|
||
.iw-form-field label {
|
||
display: block; font-size: 13px; font-weight: 500;
|
||
color: var(--text-primary, #111827); margin-bottom: 4px;
|
||
}
|
||
.iw-form-field label .iw-optional {
|
||
font-weight: 400; font-size: 11px; color: var(--text-secondary, #9ca3af);
|
||
margin-left: 4px;
|
||
}
|
||
.iw-form-field input {
|
||
width: 100%; box-sizing: border-box;
|
||
padding: 8px 10px; border-radius: 6px;
|
||
border: 1px solid var(--border, #e5e7eb);
|
||
background: var(--surface, #fff); font-size: 13px;
|
||
font-family: inherit;
|
||
}
|
||
.iw-form-field input:focus {
|
||
outline: none; border-color: var(--primary, #6366f1);
|
||
box-shadow: 0 0 0 2px rgba(99, 102, 241, 0.15);
|
||
}
|
||
.iw-form-field .field-help {
|
||
font-size: 11px; color: var(--text-secondary, #6b7280); margin-top: 4px;
|
||
}
|
||
</style>
|
||
<div class="modal-card" style="max-width: 480px;">
|
||
<h3 id="iw-modal-title">Link to Template Repository</h3>
|
||
<p class="sub" id="iw-modal-sub">Register a Git repo whose contents will replace the default <code>agnes init</code> workspace skeleton.</p>
|
||
|
||
<div class="iw-form-field">
|
||
<label for="iw-url">Repository URL (HTTPS)</label>
|
||
<input type="text" id="iw-url" placeholder="https://github.com/your-org/agnes-workspace-template" autocomplete="off">
|
||
<div class="field-help">Must be <code>https://</code>. Public repo or PAT-authed private.</div>
|
||
</div>
|
||
|
||
<div class="iw-form-field">
|
||
<label for="iw-branch">Branch <span class="iw-optional">(optional)</span></label>
|
||
<input type="text" id="iw-branch" placeholder="main" autocomplete="off">
|
||
<div class="field-help">Leave empty to track the remote's default branch.</div>
|
||
</div>
|
||
|
||
<div class="iw-form-field">
|
||
<label for="iw-token">GitHub PAT <span class="iw-optional">(optional)</span></label>
|
||
<input type="password" id="iw-token" placeholder="ghp_••• (leave blank to keep existing)" autocomplete="off">
|
||
<div class="field-help">
|
||
Required only for private repos. Stored at <code>.env_overlay</code>
|
||
(chmod 600), never in the YAML overlay. Leave blank to keep an
|
||
existing PAT; type a value to rotate.
|
||
</div>
|
||
</div>
|
||
|
||
<div class="modal-actions">
|
||
<button class="cfg-btn" data-close-modal="iw-modal">Cancel</button>
|
||
<button class="cfg-btn primary" id="iw-modal-save">Save</button>
|
||
</div>
|
||
</div>
|
||
</div>
|
||
|
||
<!-- Initial Workspace Template — sync result modal -->
|
||
<div class="modal-backdrop" id="iw-sync-modal" role="dialog" aria-modal="true" aria-labelledby="iw-sync-title">
|
||
<div class="modal-card" style="max-width: 520px;">
|
||
<h3 id="iw-sync-title">Sync result</h3>
|
||
<div id="iw-sync-body" class="diff-list" style="background: var(--border-light, #f9fafb);"></div>
|
||
<div class="modal-actions">
|
||
<button class="cfg-btn primary" data-close-modal="iw-sync-modal">Close</button>
|
||
</div>
|
||
</div>
|
||
</div>
|
||
|
||
<!-- Danger-zone confirmation modal -->
|
||
<div class="modal-backdrop" id="danger-modal" role="dialog" aria-modal="true" aria-labelledby="danger-title">
|
||
<div class="modal-card">
|
||
<h3 id="danger-title">Confirm danger-zone change</h3>
|
||
<p class="sub" id="danger-sub"></p>
|
||
<div class="diff-list" id="danger-diff"></div>
|
||
<p class="sub"><strong>Save anyway?</strong> An app restart is required for the change to take effect.</p>
|
||
<div class="modal-actions">
|
||
<button class="cfg-btn" data-close-modal="danger-modal">Cancel</button>
|
||
<button class="cfg-btn danger" id="danger-confirm-btn">Yes, save</button>
|
||
</div>
|
||
</div>
|
||
</div>
|
||
|
||
<script>
|
||
const CFG_API = "/api/admin/server-config";
|
||
|
||
// Secret-key heuristic — must match the server's _is_secret_key() patterns
|
||
// so the UI redacts the same fields the API would mask. Re-defined here
|
||
// instead of fetched so a render with the pre-loaded redacted payload
|
||
// still labels every secret field correctly even before the GET resolves.
|
||
const SECRET_PATTERNS = ["secret", "token", "password", "api_key"];
|
||
function isSecretKey(key) {
|
||
const k = (key || "").toLowerCase();
|
||
return SECRET_PATTERNS.some(p => k.includes(p));
|
||
}
|
||
|
||
// Section copy — kept short; the issue's Scope section explains the rest.
|
||
const SECTION_META = {
|
||
instance: { title: "Instance", help: "Branding shown in the header and emails." },
|
||
data_source: { title: "Data source", help: "Switch source type or update connection details. Optional BQ + Keboola knobs render below as structured fields with hints; expand each to edit." },
|
||
email: { title: "Email (SMTP)", help: "SMTP relay for magic-link login. Leave blank to disable." },
|
||
telegram: { title: "Telegram", help: "Bot credentials for notifications." },
|
||
jira: { title: "Jira", help: "Jira webhook + REST credentials." },
|
||
theme: { title: "Theme", help: "Brand colors and typography." },
|
||
server: { title: "Server", help: "Hostname and host. Changing these can break OAuth callbacks." },
|
||
auth: { title: "Authentication", help: "Allowed sign-in domain and Google OAuth keys. Misconfiguration can lock everyone out." },
|
||
ai: { title: "AI / LLM", help: "Provider + API key for the corporate-memory extractor. provider=anthropic|openai_compat; api_key uses ${ENV_VAR} so the secret stays in .env." },
|
||
openmetadata: { title: "OpenMetadata", help: "Optional REST catalog enrichment. Without it, the app runs without catalog cross-links." },
|
||
desktop: { title: "Desktop app", help: "JWT auth for the desktop client (rarely changed)." },
|
||
corporate_memory: {
|
||
title: "Corporate Memory",
|
||
help: "Optional governance for AI-extracted knowledge. When the section is unset, the system runs in legacy democratic-wiki mode with no admin review.",
|
||
},
|
||
materialize: {
|
||
title: "Materialize",
|
||
help: "Concurrency safety net for the materialize path. Controls the file-lock TTL used to detect and reclaim stale locks from hard-killed processes.",
|
||
},
|
||
guardrails: {
|
||
title: "Flea-market guardrails",
|
||
help: "Per-component content quality thresholds for store uploads. Lower the min-* knobs to relax the bar; raise to push submitters toward longer, more useful descriptions. The LLM tier (review_model + enabled) governs the second-stage substantive review.",
|
||
},
|
||
};
|
||
const DANGER_SECTIONS = new Set(["auth", "server"]);
|
||
|
||
// ── Banner ─────────────────────────────────────────────────────────────
|
||
function showBanner(msg, kind) {
|
||
const el = document.getElementById("cfg-banner");
|
||
el.textContent = msg;
|
||
el.className = "cfg-banner is-visible" + (kind ? " " + kind : "");
|
||
}
|
||
function hideBanner() {
|
||
document.getElementById("cfg-banner").className = "cfg-banner";
|
||
}
|
||
|
||
// ── Modal helpers ─────────────────────────────────────────────────────
|
||
function openModal(id) { document.getElementById(id).classList.add("is-open"); }
|
||
function closeModal(id) { document.getElementById(id).classList.remove("is-open"); }
|
||
document.querySelectorAll("[data-close-modal]").forEach(el =>
|
||
el.addEventListener("click", () => closeModal(el.dataset.closeModal)));
|
||
document.querySelectorAll(".modal-backdrop").forEach(el => {
|
||
el.addEventListener("click", e => { if (e.target === el) el.classList.remove("is-open"); });
|
||
});
|
||
|
||
// ── State ─────────────────────────────────────────────────────────────
|
||
// `original` keeps the redacted payload from GET — used for the diff
|
||
// preview in the danger-zone confirmation. Don't mutate it after load.
|
||
let original = {};
|
||
|
||
// ── Render ────────────────────────────────────────────────────────────
|
||
function escHtml(s) {
|
||
// textContent → innerHTML only escapes <, >, &. We splice the result
|
||
// into HTML attribute values like `value="${escHtml(v)}"`, where a
|
||
// raw " breaks out of the attribute and a raw ' breaks out when the
|
||
// attribute uses single quotes — both are stored-XSS vectors when
|
||
// config values come from a malicious admin. Escape both explicitly.
|
||
const d = document.createElement("div");
|
||
d.textContent = s == null ? "" : String(s);
|
||
return d.innerHTML.replace(/"/g, """).replace(/'/g, "'");
|
||
}
|
||
|
||
// Encode a segment array as a JSON-string suitable for an HTML attribute.
|
||
// We store the path as JSON rather than dot-joined so that map keys (which
|
||
// are user-supplied data and can themselves contain '.', e.g.
|
||
// "user_verification.correction" in confidence.base) round-trip intact —
|
||
// splitting `data-key` on '.' would shred them into bogus extra segments.
|
||
function encodePath(segments) {
|
||
return escHtml(JSON.stringify(segments || []));
|
||
}
|
||
|
||
// Build a basic <input>/<select>/<textarea> for a leaf field. Returns the
|
||
// HTML for the input element only — the wrapping <div class="cfg-field">
|
||
// + label + hint is added by the caller.
|
||
//
|
||
// `pathSegments` is the array of registry path segments down to this leaf
|
||
// (e.g. ["bigquery", "billing_project"]). It's emitted as a JSON-encoded
|
||
// `data-path` attribute that the collector reads to rebuild the nested
|
||
// patch shape — bypassing the old dotted-string-splitting which would
|
||
// mis-parse map keys with embedded dots.
|
||
//
|
||
// `dottedKey` is kept for backward-compat / debugging; collectSection
|
||
// prefers data-path when present.
|
||
function renderLeafInput(fieldId, section, pathSegments, kind, value, opts, isUnset) {
|
||
const dottedKey = (pathSegments || []).join(".");
|
||
const dataPath = encodePath(pathSegments);
|
||
const leafKey = pathSegments && pathSegments.length ? pathSegments[pathSegments.length - 1] : "";
|
||
const isSecret = isSecretKey(String(leafKey)) || kind === "secret";
|
||
if (kind === "secret") {
|
||
const ph = isUnset
|
||
? "unset — type to set"
|
||
: (value === "<empty>" ? "unset — type to set" : "*** — type to overwrite");
|
||
return `<input id="${fieldId}" type="password" class="is-secret" data-section="${section}" data-key="${escHtml(dottedKey)}" data-path="${dataPath}" placeholder="${escHtml(ph)}" autocomplete="off">`;
|
||
}
|
||
if (kind === "int") {
|
||
const v = (value == null || value === "") ? "" : value;
|
||
return `<input id="${fieldId}" type="number" data-section="${section}" data-key="${escHtml(dottedKey)}" data-path="${dataPath}" value="${escHtml(v)}">`;
|
||
}
|
||
if (kind === "float") {
|
||
const v = (value == null || value === "") ? "" : value;
|
||
return `<input id="${fieldId}" type="number" step="any" data-section="${section}" data-key="${escHtml(dottedKey)}" data-path="${dataPath}" data-cast="float" value="${escHtml(v)}">`;
|
||
}
|
||
if (kind === "bool") {
|
||
const v = !!value;
|
||
return `<select id="${fieldId}" data-section="${section}" data-key="${escHtml(dottedKey)}" data-path="${dataPath}" data-cast="bool">
|
||
<option value="true" ${v ? "selected" : ""}>true</option>
|
||
<option value="false" ${!v ? "selected" : ""}>false</option>
|
||
</select>`;
|
||
}
|
||
if (kind === "select" && Array.isArray(opts && opts.spec && opts.spec.options)) {
|
||
const sel = value == null ? "" : String(value);
|
||
const options = opts.spec.options.map(o => {
|
||
const ov = String(o);
|
||
return `<option value="${escHtml(ov)}" ${sel === ov ? "selected" : ""}>${escHtml(ov)}</option>`;
|
||
}).join("");
|
||
return `<select id="${fieldId}" data-section="${section}" data-key="${escHtml(dottedKey)}" data-path="${dataPath}">${options}</select>`;
|
||
}
|
||
// Default: text. Use the registry's default when unset, else the value.
|
||
const v = isUnset
|
||
? (opts && opts.spec && opts.spec.default != null ? String(opts.spec.default) : "")
|
||
: (value == null ? "" : value);
|
||
// Issue #160 §4.7.5: `placeholder_from: ["a","b","c"]` walks the loaded
|
||
// `original` config dict and shows "(defaults to <resolved>)" greyed in
|
||
// the empty input. Used by data_source.bigquery.billing_project to
|
||
// surface the access.py:339-340 billing→data fallback in the UI.
|
||
let placeholderAttr = "";
|
||
if (isUnset && opts && opts.spec && Array.isArray(opts.spec.placeholder_from)) {
|
||
// `original` is the full GET /api/admin/server-config response shape:
|
||
// {sections: {data_source: ...}, editable_sections: [...], ...}.
|
||
// `placeholder_from` is a section-relative path (e.g. ["data_source",
|
||
// "bigquery", "project"]) so walk `original.sections` not `original`.
|
||
const resolved = opts.spec.placeholder_from.reduce(
|
||
(cur, k) => (cur && typeof cur === "object" ? cur[k] : undefined),
|
||
original && original.sections ? original.sections : original,
|
||
);
|
||
if (resolved !== undefined && resolved !== null && resolved !== "") {
|
||
placeholderAttr = ` placeholder="(defaults to ${escHtml(String(resolved))})"`;
|
||
}
|
||
}
|
||
return `<input id="${fieldId}" type="text" data-section="${section}" data-key="${escHtml(dottedKey)}" data-path="${dataPath}" value="${escHtml(v)}"${placeholderAttr}>`;
|
||
}
|
||
|
||
// Cast a string raw value to the JS type implied by an item_kind / value_kind.
|
||
// Used by the array-of-scalars + map-of-scalars renderers when reading user
|
||
// input back out into a structured patch.
|
||
function castScalar(raw, kind) {
|
||
if (raw === "" || raw == null) return null;
|
||
if (kind === "int") {
|
||
const n = Number(raw);
|
||
return Number.isFinite(n) ? Math.trunc(n) : null;
|
||
}
|
||
if (kind === "float") {
|
||
const n = Number(raw);
|
||
return Number.isFinite(n) ? n : null;
|
||
}
|
||
if (kind === "bool") {
|
||
return raw === "true" || raw === true;
|
||
}
|
||
return String(raw);
|
||
}
|
||
|
||
// Render an array of scalars (e.g. detection_types: ["correction", ...]).
|
||
// Produces a vertical stack of text inputs, one per item, plus an add/remove
|
||
// affordance per row and a trailing "+ Add" button. The container's
|
||
// data-array-collect path collects each row's value at save time.
|
||
function renderArrayField(section, pathSegments, label, value, spec, depth) {
|
||
spec = spec || {};
|
||
const indent = (depth || 0) * 24;
|
||
const itemKind = spec.item_kind || "string";
|
||
const items = Array.isArray(value) ? value
|
||
: (value === undefined && Array.isArray(spec.default) ? spec.default : []);
|
||
const dataPath = encodePath(pathSegments);
|
||
const dottedKey = (pathSegments || []).join(".");
|
||
const arrow = depth > 0 ? "↳ " : "";
|
||
const hintBlock = spec.hint
|
||
? `<div class="field-help">${escHtml(spec.hint)}</div>`
|
||
: "";
|
||
// `data-array-collect="1"` marks the wrapper so collectSection can pick
|
||
// it up as a single unit (otherwise the per-row inputs would each emit
|
||
// their own patch leaf and clobber each other).
|
||
const rows = items.map((item, idx) => `
|
||
<div class="array-row" data-array-row="${idx}" style="display: flex; gap: 6px; margin-bottom: 4px;">
|
||
<input type="text" class="array-item-input" data-array-item="${idx}" value="${escHtml(item == null ? "" : String(item))}" style="flex: 1;">
|
||
<button type="button" class="cfg-btn" data-array-remove="${idx}" title="Remove this item">×</button>
|
||
</div>`).join("");
|
||
return `
|
||
<div class="cfg-field nested-field" style="margin-left: ${indent}px;">
|
||
<label>${arrow}${escHtml(label)}</label>
|
||
<div>
|
||
<div class="array-container"
|
||
data-section="${section}"
|
||
data-key="${escHtml(dottedKey)}"
|
||
data-path="${dataPath}"
|
||
data-array-collect="1"
|
||
data-item-kind="${escHtml(itemKind)}">
|
||
<div class="array-rows">${rows}</div>
|
||
<button type="button" class="cfg-btn" data-array-add="1" data-item-kind="${escHtml(itemKind)}">+ Add item</button>
|
||
</div>
|
||
${hintBlock}
|
||
</div>
|
||
</div>`;
|
||
}
|
||
|
||
// Render a map of string → scalar/array/object (e.g. confidence.base:
|
||
// {"user_verification.correction": 0.9, ...}). Produces a vertical stack
|
||
// of <key-input>: <value-input> rows plus a "+ Add row" button. Map keys
|
||
// are user-supplied data and may contain dots — we never reuse them as
|
||
// path segments at collect time; instead they become the *final* path
|
||
// segment of each row, JSON-encoded so collectors don't split them.
|
||
function renderMapField(section, pathSegments, label, value, spec, depth) {
|
||
spec = spec || {};
|
||
const indent = (depth || 0) * 24;
|
||
const valueKind = spec.value_kind || "string";
|
||
const valueItemKind = spec.value_item_kind || "string"; // for value_kind="array"
|
||
// Use registry default only when the value is genuinely missing (undefined).
|
||
// An explicit empty {} from YAML must not get backfilled with the example default.
|
||
const obj = (value && typeof value === "object" && !Array.isArray(value))
|
||
? value
|
||
: (value === undefined && spec.default && typeof spec.default === "object" ? spec.default : {});
|
||
const dataPath = encodePath(pathSegments);
|
||
const dottedKey = (pathSegments || []).join(".");
|
||
const arrow = depth > 0 ? "↳ " : "";
|
||
const hintBlock = spec.hint
|
||
? `<div class="field-help">${escHtml(spec.hint)}</div>`
|
||
: "";
|
||
const renderRow = (k, v, idx) => {
|
||
if (valueKind === "array") {
|
||
// Map<string, array<scalar>> — value column is itself a comma-separated
|
||
// text input. Operator can edit the list inline; collectSection splits
|
||
// on commas. (Full nested array UI inside a map row would require more
|
||
// wiring; comma-list is the pragmatic compromise.)
|
||
const items = Array.isArray(v) ? v.join(", ") : "";
|
||
return `
|
||
<div class="map-row" data-map-row="${idx}" style="display: grid; grid-template-columns: minmax(160px, 1fr) 2fr auto; gap: 6px; margin-bottom: 4px;">
|
||
<input type="text" class="map-key-input" data-map-key="${idx}" value="${escHtml(String(k))}" placeholder="key">
|
||
<input type="text" class="map-value-input" data-map-value="${idx}" value="${escHtml(items)}" placeholder="comma,separated,values">
|
||
<button type="button" class="cfg-btn" data-map-remove="${idx}" title="Remove this row">×</button>
|
||
</div>`;
|
||
}
|
||
// Scalar value column.
|
||
const inputType = (valueKind === "int" || valueKind === "float") ? "number" : "text";
|
||
const stepAttr = valueKind === "float" ? ' step="any"' : "";
|
||
return `
|
||
<div class="map-row" data-map-row="${idx}" style="display: grid; grid-template-columns: minmax(160px, 1fr) 1fr auto; gap: 6px; margin-bottom: 4px;">
|
||
<input type="text" class="map-key-input" data-map-key="${idx}" value="${escHtml(String(k))}" placeholder="key">
|
||
<input type="${inputType}"${stepAttr} class="map-value-input" data-map-value="${idx}" value="${escHtml(v == null ? "" : String(v))}" placeholder="value">
|
||
<button type="button" class="cfg-btn" data-map-remove="${idx}" title="Remove this row">×</button>
|
||
</div>`;
|
||
};
|
||
const rows = Object.entries(obj).map(([k, v], idx) => renderRow(k, v, idx)).join("");
|
||
return `
|
||
<div class="cfg-field nested-field" style="margin-left: ${indent}px;">
|
||
<label>${arrow}${escHtml(label)}</label>
|
||
<div>
|
||
<div class="map-container"
|
||
data-section="${section}"
|
||
data-key="${escHtml(dottedKey)}"
|
||
data-path="${dataPath}"
|
||
data-map-collect="1"
|
||
data-value-kind="${escHtml(valueKind)}"
|
||
data-value-item-kind="${escHtml(valueItemKind)}">
|
||
<div class="map-rows">${rows}</div>
|
||
<button type="button" class="cfg-btn" data-map-add="1" data-value-kind="${escHtml(valueKind)}">+ Add row</button>
|
||
</div>
|
||
${hintBlock}
|
||
</div>
|
||
</div>`;
|
||
}
|
||
|
||
// Render a single nested subfield row recursively. Each leaf input carries
|
||
// `data-path` (JSON-encoded segment array) so collectSection can rebuild
|
||
// the nested patch shape without splitting on '.' — important for map keys
|
||
// that themselves contain dots (e.g. confidence.base keys like
|
||
// "user_verification.correction").
|
||
//
|
||
// Recursion: arbitrary depth supported. When a child spec has kind="object"
|
||
// with its own `fields` map, we recurse with the indent bumped up. The depth
|
||
// bound is implicit (browser stack); registries with ridiculous depth would
|
||
// blow up, but the entries we ship max out around 4 levels (corporate_memory
|
||
// in subagent 3) which is comfortably within budget.
|
||
//
|
||
// `pathSegments` — array of registry path segments down to this field (e.g.
|
||
// ["bigquery", "billing_project"]). Used both for the rendered data-path
|
||
// attribute and to derive the legacy dotted key for back-compat.
|
||
function renderNestedField(section, pathSegments, label, value, spec, depth) {
|
||
spec = spec || {};
|
||
const segs = Array.isArray(pathSegments) ? pathSegments : [pathSegments];
|
||
const dottedKey = segs.join(".");
|
||
const indent = (depth || 0) * 24;
|
||
const kind = spec.kind || (
|
||
Array.isArray(value) ? "array"
|
||
: typeof value === "number" ? "int"
|
||
: typeof value === "boolean" ? "bool"
|
||
: (value && typeof value === "object") ? "object"
|
||
: "string"
|
||
);
|
||
const isSecret = isSecretKey(label) || kind === "secret";
|
||
const isUnset = (value === undefined);
|
||
const fieldId = `f_${section}_${dottedKey.replace(/\W/g, "_")}`;
|
||
const wrapperClass = "cfg-field nested-field" + (isUnset ? " is-unset" : "");
|
||
const arrow = depth > 0 ? "↳ " : "";
|
||
const secretPill = isSecret ? '<span class="secret-pill">secret</span>' : "";
|
||
const hintBlock = spec.hint
|
||
? `<div class="field-help">${escHtml(spec.hint)}</div>`
|
||
: "";
|
||
|
||
// Array-of-scalars: dedicated stack-of-inputs renderer.
|
||
if (kind === "array" && spec.item_kind && spec.item_kind !== "object") {
|
||
return renderArrayField(section, segs, label, value, spec, depth);
|
||
}
|
||
|
||
// Map<string, …>: dedicated key/value-row renderer. Handles map of scalars,
|
||
// map of arrays, and (with a JSON-textarea fallback) map of complex objects.
|
||
if (kind === "map") {
|
||
if (spec.value_kind === "object" && spec.value_fields && Object.keys(spec.value_fields).length > 0) {
|
||
// TODO: structured editor for "map of objects with declared subfields"
|
||
// (e.g. confidence.modifiers — Map<string, Map<string, float>>).
|
||
// Falls through to the JSON-textarea fallback below for now.
|
||
} else {
|
||
return renderMapField(section, segs, label, value, spec, depth);
|
||
}
|
||
}
|
||
|
||
// Registry-declared object with explicit fields → recurse for each child
|
||
// as a structured form; emit a header row for the parent.
|
||
if (kind === "object" && spec.fields && typeof spec.fields === "object") {
|
||
const childValue = (value && typeof value === "object" && !Array.isArray(value)) ? value : {};
|
||
const knownChildKeys = Object.keys(spec.fields);
|
||
const knownSet = new Set(knownChildKeys);
|
||
const populatedChildKeys = Object.keys(childValue).filter(k => knownSet.has(k));
|
||
const unsetChildKeys = knownChildKeys.filter(k => !(k in childValue));
|
||
|
||
// YAML-only keys that aren't in the registry — preserve via a small JSON
|
||
// expander so admins who hand-edited an unusual key in the YAML don't
|
||
// lose it on round-trip. Keys are still editable as a single JSON blob
|
||
// (deliberately less prominent than registry-known leaves).
|
||
const fallbackKeys = Object.keys(childValue).filter(k => !knownSet.has(k));
|
||
const fallbackBlob = fallbackKeys.length
|
||
? Object.fromEntries(fallbackKeys.map(k => [k, childValue[k]]))
|
||
: null;
|
||
|
||
const renderChild = (k) => renderNestedField(
|
||
section,
|
||
segs.concat([k]),
|
||
k,
|
||
(k in childValue) ? childValue[k] : undefined,
|
||
spec.fields[k] || {},
|
||
(depth || 0) + 1,
|
||
);
|
||
|
||
const populatedHtml = populatedChildKeys.sort().map(renderChild).join("");
|
||
const unsetHtml = unsetChildKeys.sort().map(renderChild).join("");
|
||
const fallbackHtml = fallbackBlob
|
||
? (() => {
|
||
const fbId = `f_${section}_${dottedKey.replace(/\W/g, "_")}_fallback`;
|
||
const fbPath = encodePath(segs.concat(["__other__"]));
|
||
// The fallback uses the same path convention with a literal
|
||
// "__other__" leaf so the collector emits it under the parent
|
||
// in collectSection. Cast=json so the textarea content
|
||
// round-trips as an object.
|
||
const indentInner = ((depth || 0) + 1) * 24;
|
||
return `
|
||
<div class="cfg-field" style="margin-left: ${indentInner}px;">
|
||
<label for="${fbId}">↳ Other (YAML-only) keys</label>
|
||
<div>
|
||
<textarea id="${fbId}" data-section="${section}" data-key="${escHtml(dottedKey + ".__other__")}" data-path="${fbPath}" data-cast="json">${escHtml(JSON.stringify(fallbackBlob, null, 2))}</textarea>
|
||
<div class="field-help">Keys present in YAML but not in the registry. Edit as a JSON object — keys at this layer survive round-trip.</div>
|
||
</div>
|
||
</div>`;
|
||
})()
|
||
: "";
|
||
|
||
return `
|
||
<div class="cfg-field nested-field nested-parent" style="margin-left: ${indent}px;">
|
||
<label>${arrow}${escHtml(label)}</label>
|
||
<div>${hintBlock || `<div class="field-help">Nested structured fields below.</div>`}</div>
|
||
</div>
|
||
${populatedHtml}${unsetHtml}${fallbackHtml}`;
|
||
}
|
||
|
||
// Leaf field (string / int / float / bool / secret / select / array,
|
||
// OR an object without explicit `fields`, OR a map with complex values
|
||
// — the last two fall back to JSON).
|
||
let inp;
|
||
if (kind === "object" || kind === "map" || kind === "array") {
|
||
// No explicit structured renderer for this shape — JSON-textarea
|
||
// fallback so a YAML-populated subtree still round-trips even
|
||
// without finer-grained schema.
|
||
const blobValue = isUnset ? "" : JSON.stringify(value || (kind === "array" ? [] : {}), null, 2);
|
||
const dataPath = encodePath(segs);
|
||
inp = `<textarea id="${fieldId}" data-section="${section}" data-key="${escHtml(dottedKey)}" data-path="${dataPath}" data-cast="json" placeholder="${isUnset ? 'unset — paste JSON to populate' : ''}">${escHtml(blobValue)}</textarea>`;
|
||
} else {
|
||
inp = renderLeafInput(fieldId, section, segs, kind, value, { spec }, isUnset);
|
||
}
|
||
|
||
return `
|
||
<div class="${wrapperClass}" style="margin-left: ${indent}px;">
|
||
<label for="${fieldId}">${arrow}${escHtml(label)}${secretPill}</label>
|
||
<div>${inp}${hintBlock}</div>
|
||
</div>`;
|
||
}
|
||
|
||
function renderField(section, key, value, opts) {
|
||
// opts: { isUnset: bool, hint: string, kind: string, spec: {…} }
|
||
// - isUnset: render the field as a dashed placeholder (.is-unset) so the
|
||
// operator can tell at a glance that the value is sourced from the
|
||
// known_fields registry rather than the live YAML.
|
||
// - hint: one-line operator-facing help (rendered as .field-help).
|
||
// - kind: registry-declared input kind. Overrides the typeof-value
|
||
// heuristic for known-but-unset entries (we have no value to inspect).
|
||
// - spec: the raw registry entry — when kind="object" + spec.fields is
|
||
// declared, we render a fully-editable structured form (every leaf is
|
||
// a real input with a dotted-path data-key so collectSection rebuilds
|
||
// the nested patch). When spec.fields is absent / the object isn't in
|
||
// the registry, we fall back to the JSON-textarea path.
|
||
opts = opts || {};
|
||
const isUnset = !!opts.isUnset;
|
||
const valueForKind = isUnset ? undefined : value;
|
||
// Registry-declared structured object → delegate to the recursive
|
||
// nested-form renderer. Replaces the old read-only preview path.
|
||
if (opts.kind === "object" && opts.spec && opts.spec.fields && typeof opts.spec.fields === "object") {
|
||
return renderNestedField(section, [key], key, valueForKind, opts.spec, 0);
|
||
}
|
||
// Pass through ALL spec fields (item_kind, key_kind, value_kind, fields,
|
||
// value_fields, default, options, hint) so the top-level entry point can
|
||
// render arrays, maps, and primitive leaves correctly.
|
||
return renderNestedField(section, [key], key, valueForKind, opts.spec || {
|
||
kind: opts.kind,
|
||
hint: opts.hint,
|
||
}, 0);
|
||
}
|
||
|
||
function renderSection(section, payload, knownForSection) {
|
||
// knownForSection: registry slice for this section, e.g.
|
||
// { bigquery: { kind: "object", hint: "...", fields: { billing_project: {...} } } }
|
||
// Keys present in `payload` render as populated; keys present in
|
||
// `knownForSection` but absent from `payload` render as dashed
|
||
// placeholders (.is-unset).
|
||
const meta = SECTION_META[section] || { title: section, help: "" };
|
||
const isDanger = DANGER_SECTIONS.has(section);
|
||
const danger = isDanger ? '<span class="danger-pill">danger</span>' : "";
|
||
const populatedKeys = Object.keys(payload || {}).sort();
|
||
const known = knownForSection || {};
|
||
const populatedSet = new Set(populatedKeys);
|
||
const knownUnsetKeys = Object.keys(known).filter(k => !populatedSet.has(k)).sort();
|
||
|
||
const populatedHtml = populatedKeys.map(k => {
|
||
const spec = known[k] || {};
|
||
return renderField(section, k, payload[k], {
|
||
isUnset: false,
|
||
hint: spec.hint || "",
|
||
kind: spec.kind, // may be undefined; renderField falls back to typeof inference
|
||
spec,
|
||
});
|
||
}).join("");
|
||
|
||
const unsetHtml = knownUnsetKeys.map(k => {
|
||
const spec = known[k] || {};
|
||
return renderField(section, k, undefined, {
|
||
isUnset: true,
|
||
hint: spec.hint || "",
|
||
kind: spec.kind || "string",
|
||
spec,
|
||
});
|
||
}).join("");
|
||
|
||
// Visual divider between populated and known-but-unset rows so the
|
||
// operator sees at a glance which knobs they're already using vs which
|
||
// ones the registry exposes for them.
|
||
const divider = (populatedHtml && unsetHtml)
|
||
? `<hr class="cfg-divider"><span class="cfg-divider-label">Available but unset</span>`
|
||
: (unsetHtml ? `<span class="cfg-divider-label">Available but unset</span>` : "");
|
||
|
||
const fieldsHtml = (populatedHtml || unsetHtml)
|
||
? (populatedHtml + divider + unsetHtml)
|
||
: `<div class="section-help">No fields populated yet — type below to add common keys, or edit the YAML directly via the API.</div>`;
|
||
// For empty sections (no populated *and* no known-but-unset), give the
|
||
// operator a textarea so they can paste a YAML/JSON blob to bootstrap
|
||
// the section. We persist it via the JSON cast so non-trivial structures
|
||
// still merge correctly.
|
||
const bootstrap = (populatedKeys.length === 0 && knownUnsetKeys.length === 0)
|
||
? `<div class="cfg-field">
|
||
<label for="bootstrap_${section}">JSON patch</label>
|
||
<div>
|
||
<textarea id="bootstrap_${section}" data-section="${section}" data-key="__bootstrap__" data-cast="json" placeholder='{"name": "Acme Analyst", ...}'></textarea>
|
||
<div class="field-help">Paste a JSON object to populate this section.</div>
|
||
</div>
|
||
</div>`
|
||
: "";
|
||
return `
|
||
<section class="cfg-section ${isDanger ? "is-danger" : ""}" data-section="${section}">
|
||
<header>
|
||
<div>
|
||
<h3>${escHtml(meta.title)}${danger}</h3>
|
||
<div class="section-help">${escHtml(meta.help)}</div>
|
||
</div>
|
||
</header>
|
||
<div class="section-body">
|
||
${fieldsHtml}
|
||
${bootstrap}
|
||
</div>
|
||
<div class="section-actions">
|
||
<button class="cfg-btn primary" data-action="save-section" data-section="${section}">Save ${escHtml(meta.title.toLowerCase())}</button>
|
||
${section === "data_source" ? `
|
||
<button class="cfg-btn" data-action="test-bigquery" type="button">Test BigQuery connection</button>
|
||
<span class="bq-test-result" data-section="${section}" hidden style="margin-left: 1ex;"></span>
|
||
` : ""}
|
||
</div>
|
||
</section>`;
|
||
}
|
||
|
||
function renderAll(data) {
|
||
const wrap = document.getElementById("cfg-sections");
|
||
const sections = data.editable_sections || Object.keys(data.sections || {});
|
||
const known = data.known_fields || {};
|
||
wrap.innerHTML = sections.map(s => renderSection(s, data.sections[s] || {}, known[s] || {})).join("");
|
||
document.getElementById("cfg-loading").style.display = "none";
|
||
wrap.hidden = false;
|
||
|
||
wrap.querySelectorAll('[data-action="save-section"]').forEach(btn =>
|
||
btn.addEventListener("click", () => onSaveSection(btn.dataset.section)));
|
||
|
||
// Issue #160 §4.9: Test BigQuery connection — admin probe to verify the
|
||
// saved data_source.bigquery config is reachable WITHOUT having to
|
||
// ssh to the VM or wait for an analyst's failed query.
|
||
wrap.querySelectorAll('[data-action="test-bigquery"]').forEach(btn =>
|
||
btn.addEventListener("click", () => onTestBigQuery(btn)));
|
||
|
||
// Wire array-of-scalars + map-of-scalars add/remove buttons via event
|
||
// delegation on the wrapper. Re-attaching after every renderAll() is
|
||
// fine because we replace innerHTML wholesale on each load.
|
||
wrap.addEventListener("click", (e) => {
|
||
const target = e.target;
|
||
if (!(target instanceof Element)) return;
|
||
// Add an array row.
|
||
if (target.dataset.arrayAdd) {
|
||
const container = target.closest('[data-array-collect="1"]');
|
||
if (!container) return;
|
||
const rows = container.querySelector('.array-rows');
|
||
const idx = rows.querySelectorAll('[data-array-row]').length;
|
||
const div = document.createElement("div");
|
||
div.className = "array-row";
|
||
div.dataset.arrayRow = String(idx);
|
||
div.style.display = "flex";
|
||
div.style.gap = "6px";
|
||
div.style.marginBottom = "4px";
|
||
div.innerHTML = `<input type="text" class="array-item-input" data-array-item="${idx}" value="" style="flex: 1;">
|
||
<button type="button" class="cfg-btn" data-array-remove="${idx}" title="Remove this item">×</button>`;
|
||
rows.appendChild(div);
|
||
const inp = div.querySelector('input');
|
||
if (inp) inp.focus();
|
||
return;
|
||
}
|
||
// Remove an array row.
|
||
if (target.dataset.arrayRemove != null) {
|
||
const row = target.closest('[data-array-row]');
|
||
if (row) row.remove();
|
||
return;
|
||
}
|
||
// Add a map row.
|
||
if (target.dataset.mapAdd) {
|
||
const container = target.closest('[data-map-collect="1"]');
|
||
if (!container) return;
|
||
const valueKind = container.dataset.valueKind || "string";
|
||
const rows = container.querySelector('.map-rows');
|
||
const idx = rows.querySelectorAll('[data-map-row]').length;
|
||
const div = document.createElement("div");
|
||
div.className = "map-row";
|
||
div.dataset.mapRow = String(idx);
|
||
div.style.display = "grid";
|
||
div.style.gridTemplateColumns = valueKind === "array"
|
||
? "minmax(160px, 1fr) 2fr auto"
|
||
: "minmax(160px, 1fr) 1fr auto";
|
||
div.style.gap = "6px";
|
||
div.style.marginBottom = "4px";
|
||
const valuePlaceholder = valueKind === "array" ? "comma,separated,values" : "value";
|
||
const inputType = (valueKind === "int" || valueKind === "float") ? "number" : "text";
|
||
const stepAttr = valueKind === "float" ? ' step="any"' : "";
|
||
div.innerHTML = `<input type="text" class="map-key-input" data-map-key="${idx}" value="" placeholder="key">
|
||
<input type="${inputType}"${stepAttr} class="map-value-input" data-map-value="${idx}" value="" placeholder="${valuePlaceholder}">
|
||
<button type="button" class="cfg-btn" data-map-remove="${idx}" title="Remove this row">×</button>`;
|
||
rows.appendChild(div);
|
||
const inp = div.querySelector('input');
|
||
if (inp) inp.focus();
|
||
return;
|
||
}
|
||
// Remove a map row.
|
||
if (target.dataset.mapRemove != null) {
|
||
const row = target.closest('[data-map-row]');
|
||
if (row) row.remove();
|
||
return;
|
||
}
|
||
});
|
||
}
|
||
|
||
// Recursively strip secret-keyed leaves whose value is the redaction sentinel
|
||
// (`***` or `<empty>`) so a JSON-textarea round-trip can't overwrite real
|
||
// overlay secrets with the placeholder shown in the form. The GET handler
|
||
// redacts secret-keyed children inside nested objects (token_env contains
|
||
// "token", so it gets masked alongside actual credentials), and the textarea
|
||
// renders the masked JSON verbatim — without this scrub a no-op save of e.g.
|
||
// `data_source.keboola` would persist `token_env: "***"` on top of the real
|
||
// value `"KEBOOLA_STORAGE_TOKEN"` and silently break the next sync.
|
||
function scrubRedactedSecrets(value) {
|
||
if (Array.isArray(value)) return value.map(scrubRedactedSecrets);
|
||
if (value && typeof value === "object") {
|
||
const out = {};
|
||
for (const [k, v] of Object.entries(value)) {
|
||
if (isSecretKey(k) && (v === "***" || v === "<empty>")) continue;
|
||
out[k] = scrubRedactedSecrets(v);
|
||
}
|
||
return out;
|
||
}
|
||
return value;
|
||
}
|
||
|
||
// Resolve the registry-path segments for a leaf input. We prefer the
|
||
// JSON-encoded `data-path` attribute (introduced for array/map renderers
|
||
// where data keys can themselves contain dots) and fall back to splitting
|
||
// the legacy `data-key` on '.' for older inputs.
|
||
//
|
||
// The "__other__" segment is the YAML-fallback expander — its parsed
|
||
// content is merged into the parent dict (not nested under the literal
|
||
// segment). See `setNested` for that special case.
|
||
function resolvePath(el) {
|
||
const raw = el.dataset && el.dataset.path;
|
||
if (raw) {
|
||
try {
|
||
const arr = JSON.parse(raw);
|
||
if (Array.isArray(arr)) return arr.map(s => String(s));
|
||
} catch (_) {
|
||
// fall through to dotted-key parsing
|
||
}
|
||
}
|
||
const dotKey = el.dataset && el.dataset.key;
|
||
if (!dotKey) return [];
|
||
return dotKey.split(".");
|
||
}
|
||
|
||
// Legacy alias kept for tests asserting on the helper name.
|
||
function splitDotted(dotKey) {
|
||
if (!dotKey) return [];
|
||
return dotKey.split(".");
|
||
}
|
||
|
||
// Set value at a nested path inside `out`, creating intermediate dicts as
|
||
// needed. The "__other__" segment is special-cased: its dict value gets
|
||
// merged into the parent rather than stored under the literal segment.
|
||
function setNested(out, segments, value) {
|
||
if (!segments.length) return;
|
||
let node = out;
|
||
for (let i = 0; i < segments.length - 1; i++) {
|
||
const seg = segments[i];
|
||
if (typeof node[seg] !== "object" || node[seg] === null || Array.isArray(node[seg])) {
|
||
node[seg] = {};
|
||
}
|
||
node = node[seg];
|
||
}
|
||
const last = segments[segments.length - 1];
|
||
if (last === "__other__") {
|
||
// Fallback expander: merge the JSON object into the parent. Skip if the
|
||
// user cleared the textarea or the value isn't an object.
|
||
if (value && typeof value === "object" && !Array.isArray(value)) {
|
||
Object.assign(node, value);
|
||
}
|
||
return;
|
||
}
|
||
node[last] = value;
|
||
}
|
||
|
||
// Collect the value of an array-of-scalars container (data-array-collect="1")
|
||
// — concatenates each non-empty row's input cast to the declared item_kind.
|
||
function collectArrayContainer(container) {
|
||
const itemKind = container.dataset.itemKind || "string";
|
||
const inputs = container.querySelectorAll('input[data-array-item]');
|
||
const out = [];
|
||
for (const inp of inputs) {
|
||
const raw = inp.value;
|
||
if (raw === "" || raw == null) continue; // drop blank rows
|
||
const cast = castScalar(raw, itemKind);
|
||
if (cast === null) continue;
|
||
out.push(cast);
|
||
}
|
||
return out;
|
||
}
|
||
|
||
// Collect the value of a map-of-scalars container (data-map-collect="1")
|
||
// — pairs each row's key-input + value-input, casting the value to the
|
||
// declared value_kind. Map keys keep their literal string form (we never
|
||
// split them on '.' — that's the whole point of the data-path/JSON encoding).
|
||
function collectMapContainer(container) {
|
||
const valueKind = container.dataset.valueKind || "string";
|
||
const valueItemKind = container.dataset.valueItemKind || "string";
|
||
const rows = container.querySelectorAll('[data-map-row]');
|
||
const out = {};
|
||
for (const row of rows) {
|
||
const keyInput = row.querySelector('[data-map-key]');
|
||
const valInput = row.querySelector('[data-map-value]');
|
||
if (!keyInput) continue;
|
||
const key = keyInput.value;
|
||
if (!key) continue; // skip incomplete rows
|
||
let value;
|
||
if (valueKind === "array") {
|
||
// Comma-separated list → array of scalars cast to value_item_kind.
|
||
const raw = valInput ? valInput.value : "";
|
||
value = raw.split(",").map(s => s.trim()).filter(s => s.length > 0)
|
||
.map(s => castScalar(s, valueItemKind))
|
||
.filter(v => v !== null);
|
||
} else {
|
||
const raw = valInput ? valInput.value : "";
|
||
value = castScalar(raw, valueKind);
|
||
if (value === null && raw === "") continue; // drop empty values
|
||
}
|
||
out[key] = value;
|
||
}
|
||
return out;
|
||
}
|
||
|
||
// ── Collect form values for one section ───────────────────────────────
|
||
function collectSection(section) {
|
||
const sectionRoot = document.querySelector(`section.cfg-section[data-section="${section}"]`)
|
||
|| document;
|
||
const patch = {};
|
||
// Track ancestor paths covered by an array/map container so we don't
|
||
// double-collect their inner inputs as individual leaves.
|
||
const handledRoots = new Set();
|
||
|
||
// 1) Array containers — collect each as a single leaf.
|
||
const arrayContainers = sectionRoot.querySelectorAll('[data-array-collect="1"]');
|
||
for (const c of arrayContainers) {
|
||
if (c.dataset.section && c.dataset.section !== section) continue;
|
||
const segments = resolvePath(c);
|
||
if (!segments.length) continue;
|
||
handledRoots.add(c);
|
||
const arr = collectArrayContainer(c);
|
||
setNested(patch, segments, arr);
|
||
}
|
||
|
||
// 2) Map containers — collect each as a single dict leaf.
|
||
const mapContainers = sectionRoot.querySelectorAll('[data-map-collect="1"]');
|
||
for (const c of mapContainers) {
|
||
if (c.dataset.section && c.dataset.section !== section) continue;
|
||
const segments = resolvePath(c);
|
||
if (!segments.length) continue;
|
||
handledRoots.add(c);
|
||
const obj = collectMapContainer(c);
|
||
setNested(patch, segments, obj);
|
||
}
|
||
|
||
// 3) Plain leaf inputs (everything outside an array/map container).
|
||
const inputs = document.querySelectorAll(`[data-section="${section}"]`);
|
||
for (const el of inputs) {
|
||
if (el.dataset.action) continue; // skip buttons
|
||
// Skip inner inputs that belong to an array/map container we already
|
||
// collected as a single unit.
|
||
if (el.closest('[data-array-collect="1"]') || el.closest('[data-map-collect="1"]')) {
|
||
// …unless the element IS itself the container (the container also
|
||
// carries data-section). In that case it was already handled above.
|
||
continue;
|
||
}
|
||
const dotKey = el.dataset.key;
|
||
if (!dotKey && !el.dataset.path) continue;
|
||
let raw = el.value;
|
||
// Skip empty secret fields — operator left them blank to preserve the
|
||
// existing value. Sending "" would overwrite the secret with empty.
|
||
if (el.classList.contains("is-secret") && raw === "") continue;
|
||
|
||
let value;
|
||
if (dotKey === "__bootstrap__") {
|
||
// Bootstrap textarea — parse the entire blob and merge it as the
|
||
// section patch. Skip empty input entirely. Scrub redacted sentinels
|
||
// out of the parsed object so a round-trip can't overwrite real
|
||
// secrets with `"***"`.
|
||
if (!raw.trim()) continue;
|
||
try { Object.assign(patch, scrubRedactedSecrets(JSON.parse(raw))); }
|
||
catch (e) { throw new Error(`Bootstrap JSON for "${section}" is not valid JSON: ${e.message}`); }
|
||
continue;
|
||
}
|
||
if (el.dataset.cast === "bool") {
|
||
value = raw === "true";
|
||
} else if (el.dataset.cast === "float") {
|
||
value = raw === "" ? null : Number(raw);
|
||
} else if (el.dataset.cast === "json") {
|
||
if (!raw.trim()) {
|
||
// Empty JSON textarea: skip entirely so a blank fallback expander
|
||
// doesn't wipe its parent. The deep-merge on the server preserves
|
||
// whatever's already on disk for this slot.
|
||
continue;
|
||
}
|
||
try { value = scrubRedactedSecrets(JSON.parse(raw)); }
|
||
catch (e) { throw new Error(`Field ${section}.${dotKey} is not valid JSON: ${e.message}`); }
|
||
} else if (el.type === "number") {
|
||
value = raw === "" ? null : Number(raw);
|
||
} else {
|
||
value = raw;
|
||
}
|
||
// If the operator left a secret-keyed scalar at the redaction sentinel
|
||
// — e.g. typed nothing into a `token_env` text input that already shows
|
||
// `"***"` — drop it rather than persisting the placeholder.
|
||
const segments = resolvePath(el);
|
||
const leafKey = segments[segments.length - 1] || "";
|
||
if (isSecretKey(leafKey) && (value === "***" || value === "<empty>")) continue;
|
||
setNested(patch, segments, value);
|
||
}
|
||
return patch;
|
||
}
|
||
|
||
// ── BigQuery test connection (#160 §4.9) ───────────────────────────────
|
||
async function onTestBigQuery(btn) {
|
||
const resultEl = btn.parentElement.querySelector(".bq-test-result");
|
||
resultEl.hidden = false;
|
||
resultEl.textContent = "Testing…";
|
||
resultEl.style.color = "";
|
||
btn.disabled = true;
|
||
try {
|
||
const r = await fetch("/api/admin/bigquery/test-connection", {
|
||
method: "POST",
|
||
credentials: "include",
|
||
});
|
||
if (r.ok) {
|
||
const body = await r.json();
|
||
resultEl.textContent = `✓ ok (${body.elapsed_ms} ms; billing=${body.billing_project}, data=${body.data_project})`;
|
||
resultEl.style.color = "#2a8c4a";
|
||
} else {
|
||
let body;
|
||
try { body = await r.json(); } catch (_) { body = await r.text(); }
|
||
const detail = body && typeof body === "object" ? body.detail : body;
|
||
const kind = detail && typeof detail === "object" ? (detail.kind || "error") : "error";
|
||
const hint = detail && typeof detail === "object" ? (detail.hint || detail.message || "") : String(detail);
|
||
resultEl.textContent = `✗ ${kind}${hint ? " — " + hint : ""}`;
|
||
resultEl.style.color = "#c0392b";
|
||
}
|
||
} catch (e) {
|
||
resultEl.textContent = `✗ network error — ${e.message}`;
|
||
resultEl.style.color = "#c0392b";
|
||
} finally {
|
||
btn.disabled = false;
|
||
}
|
||
}
|
||
|
||
// ── Save flow ─────────────────────────────────────────────────────────
|
||
async function onSaveSection(section) {
|
||
hideBanner();
|
||
let patch;
|
||
try { patch = collectSection(section); }
|
||
catch (e) { showBanner(e.message, "error"); return; }
|
||
|
||
if (Object.keys(patch).length === 0) {
|
||
showBanner(`No changes to save in "${section}".`);
|
||
return;
|
||
}
|
||
|
||
const isDanger = DANGER_SECTIONS.has(section);
|
||
if (isDanger) {
|
||
const confirmed = await confirmDanger(section, patch);
|
||
if (!confirmed) return;
|
||
}
|
||
|
||
await postPatch(section, patch, isDanger);
|
||
}
|
||
|
||
function diffPreview(section, patch) {
|
||
// Compare patch fields against the redacted original snapshot. Shows the
|
||
// operator exactly which keys they're about to change before they
|
||
// confirm a danger-zone save.
|
||
const before = (original.sections && original.sections[section]) || {};
|
||
const rows = [];
|
||
for (const [k, v] of Object.entries(patch)) {
|
||
const b = before[k];
|
||
if (JSON.stringify(b) !== JSON.stringify(v)) {
|
||
rows.push({ path: `${section}.${k}`, before: b, after: v });
|
||
}
|
||
}
|
||
return rows;
|
||
}
|
||
|
||
function confirmDanger(section, patch) {
|
||
return new Promise(resolve => {
|
||
const rows = diffPreview(section, patch);
|
||
const sub = `You're about to change the <strong>${escHtml(section)}</strong> section. ` +
|
||
`This is flagged as danger-zone — a typo here can lock you out or break OAuth callbacks.`;
|
||
document.getElementById("danger-sub").innerHTML = sub;
|
||
document.getElementById("danger-diff").innerHTML = rows.length
|
||
? rows.map(r => `<div class="diff-row"><span class="path">${escHtml(r.path)}</span> — ${escHtml(JSON.stringify(r.before))} → <strong>${escHtml(JSON.stringify(r.after))}</strong></div>`).join("")
|
||
: `<em>No visible diff (secret fields are masked in this preview).</em>`;
|
||
const btn = document.getElementById("danger-confirm-btn");
|
||
const modalEl = document.getElementById("danger-modal");
|
||
const cancelBtns = document.querySelectorAll('#danger-modal [data-close-modal]');
|
||
const onOk = () => { closeModal("danger-modal"); cleanup(); resolve(true); };
|
||
const onCancel = () => { cleanup(); resolve(false); };
|
||
// Backdrop click visually closes via the global handler at the top of the
|
||
// file, but that handler doesn't know about the Promise — without this
|
||
// listener the await would hang and stack listeners on the next save.
|
||
const onBackdrop = (e) => { if (e.target === modalEl) { cleanup(); resolve(false); } };
|
||
function cleanup() {
|
||
btn.removeEventListener("click", onOk);
|
||
modalEl.removeEventListener("click", onBackdrop);
|
||
cancelBtns.forEach(b => b.removeEventListener("click", onCancel));
|
||
}
|
||
btn.addEventListener("click", onOk, { once: true });
|
||
modalEl.addEventListener("click", onBackdrop);
|
||
cancelBtns.forEach(b => b.addEventListener("click", onCancel, { once: true }));
|
||
openModal("danger-modal");
|
||
});
|
||
}
|
||
|
||
async function postPatch(section, patch, confirmDanger) {
|
||
try {
|
||
const r = await fetch(CFG_API, {
|
||
method: "POST", credentials: "include",
|
||
headers: { "Content-Type": "application/json" },
|
||
body: JSON.stringify({ sections: { [section]: patch }, confirm_danger: confirmDanger }),
|
||
});
|
||
const data = await r.json().catch(() => ({}));
|
||
if (!r.ok) {
|
||
showBanner(`Save failed: ${data.detail || r.statusText}`, "error");
|
||
return;
|
||
}
|
||
showBanner(
|
||
`Saved "${section}" (${data.diff_count} field(s) changed). Restart the app for the change to take effect.`,
|
||
"success",
|
||
);
|
||
// Re-fetch so the form reflects the new (still-redacted) state.
|
||
await loadConfig();
|
||
} catch (e) {
|
||
showBanner(`Save failed: ${e.message}`, "error");
|
||
}
|
||
}
|
||
|
||
// ── Init ──────────────────────────────────────────────────────────────
|
||
async function loadConfig() {
|
||
try {
|
||
const r = await fetch(CFG_API, { credentials: "include" });
|
||
if (!r.ok) throw new Error("HTTP " + r.status);
|
||
original = await r.json();
|
||
renderAll(original);
|
||
} catch (e) {
|
||
document.getElementById("cfg-loading").textContent = "Failed to load config: " + e.message;
|
||
}
|
||
}
|
||
|
||
loadConfig();
|
||
|
||
// ════════════════════════════════════════════════════════════════════════
|
||
// Initial Workspace Template — dedicated lifecycle (NOT part of generic
|
||
// instance.yaml form save). Data routes through /api/admin/initial-workspace
|
||
// because of PAT routing to .env_overlay.
|
||
// ════════════════════════════════════════════════════════════════════════
|
||
|
||
const IW_API = "/api/admin/initial-workspace";
|
||
|
||
async function iwLoad() {
|
||
const body = document.getElementById("iw-body");
|
||
const actions = document.getElementById("iw-actions");
|
||
body.innerHTML = '<div class="cfg-loading">Loading…</div>';
|
||
actions.hidden = true;
|
||
actions.innerHTML = "";
|
||
try {
|
||
const r = await fetch(IW_API, { credentials: "include" });
|
||
if (!r.ok) throw new Error("HTTP " + r.status);
|
||
const data = await r.json();
|
||
iwRender(data);
|
||
} catch (e) {
|
||
body.innerHTML = `<div class="cfg-loading">Failed to load: ${escHtml(e.message)}</div>`;
|
||
}
|
||
}
|
||
|
||
function iwRender(data) {
|
||
const body = document.getElementById("iw-body");
|
||
const actions = document.getElementById("iw-actions");
|
||
if (!data.configured) {
|
||
// Empty state — mirror the bootstrap-textarea pattern used by other
|
||
// sections when they have no data yet: friendly explanation in the
|
||
// body, primary action in the section-actions footer.
|
||
body.innerHTML = `
|
||
<div class="section-help" style="font-size: 13px;">
|
||
No template repository linked. Click <strong>Link to Template Repository</strong>
|
||
to register one. The repo's contents will replace the default
|
||
<code>agnes init</code> workspace skeleton for every analyst on this instance.
|
||
</div>
|
||
`;
|
||
actions.innerHTML = `<button class="cfg-btn primary" id="iw-register-btn">Link to Template Repository</button>`;
|
||
actions.hidden = false;
|
||
document.getElementById("iw-register-btn").addEventListener("click", () => {
|
||
iwOpenModal(/* editing */ false, null);
|
||
});
|
||
return;
|
||
}
|
||
// Configured — render label/value pairs using the same .cfg-field grid
|
||
// layout the other sections use, so the panel reads as part of the page.
|
||
const syncedAt = data.last_synced_at
|
||
? new Date(data.last_synced_at).toLocaleString()
|
||
: "never";
|
||
const sha = data.last_commit_sha
|
||
? `<code>${escHtml(data.last_commit_sha.slice(0, 10))}</code>`
|
||
: '<span style="color: var(--text-secondary, #9ca3af);">never synced</span>';
|
||
const tokenLine = data.has_token
|
||
? '<span class="secret-pill" style="background:#dcfce7;color:#166534;border-color:#86efac;">PAT set</span>'
|
||
: '<span class="secret-pill" style="background:#f3f4f6;color:#6b7280;">no PAT</span>';
|
||
const lastError = data.last_error
|
||
? `<div class="cfg-field"><label>Last sync error</label><div><div class="cfg-banner error is-visible" style="margin:0;">${escHtml(data.last_error)}</div></div></div>`
|
||
: "";
|
||
body.innerHTML = `
|
||
<div class="cfg-field">
|
||
<label>Repository URL</label>
|
||
<div><code>${escHtml(data.url)}</code></div>
|
||
</div>
|
||
<div class="cfg-field">
|
||
<label>Branch</label>
|
||
<div>${data.branch ? `<code>${escHtml(data.branch)}</code>` : '<span style="color: var(--text-secondary, #9ca3af);">(remote default)</span>'}</div>
|
||
</div>
|
||
<div class="cfg-field">
|
||
<label>GitHub PAT</label>
|
||
<div>${tokenLine}</div>
|
||
</div>
|
||
<div class="cfg-field">
|
||
<label>Last sync</label>
|
||
<div>${escHtml(syncedAt)} · commit ${sha} · ${data.file_count} file(s)</div>
|
||
</div>
|
||
${lastError}
|
||
`;
|
||
// Download button uses the same analyst-facing endpoint so what the
|
||
// admin downloads is byte-identical to what `agnes init` extracts on
|
||
// an analyst's laptop. Disabled (rendered as a faded button) when not
|
||
// synced — endpoint would return 503. Browser session cookie carries
|
||
// auth (get_current_user accepts cookie + Bearer).
|
||
const downloadBtn = data.last_commit_sha
|
||
? `<a class="cfg-btn" id="iw-download-btn" href="/api/initial-workspace.zip" download="initial-workspace.zip">Download zip</a>`
|
||
: `<button class="cfg-btn" disabled title="No synced commit yet — click Sync now first">Download zip</button>`;
|
||
actions.innerHTML = `
|
||
<button class="cfg-btn primary" id="iw-sync-btn">Sync now</button>
|
||
${downloadBtn}
|
||
<button class="cfg-btn" id="iw-edit-btn">Edit</button>
|
||
<button class="cfg-btn danger" id="iw-delete-btn">Delete</button>
|
||
`;
|
||
actions.hidden = false;
|
||
document.getElementById("iw-sync-btn").addEventListener("click", iwSync);
|
||
document.getElementById("iw-edit-btn").addEventListener("click", () => {
|
||
iwOpenModal(/* editing */ true, data);
|
||
});
|
||
document.getElementById("iw-delete-btn").addEventListener("click", iwDelete);
|
||
}
|
||
|
||
function iwOpenModal(editing, data) {
|
||
document.getElementById("iw-modal-title").textContent =
|
||
editing ? "Edit Template Repository" : "Link to Template Repository";
|
||
document.getElementById("iw-url").value = (editing && data) ? (data.url || "") : "";
|
||
document.getElementById("iw-branch").value = (editing && data) ? (data.branch || "") : "";
|
||
document.getElementById("iw-token").value = ""; // Never prefill PAT
|
||
openModal("iw-modal");
|
||
}
|
||
|
||
async function iwSave() {
|
||
const url = document.getElementById("iw-url").value.trim();
|
||
const branch = document.getElementById("iw-branch").value.trim();
|
||
const token = document.getElementById("iw-token").value;
|
||
if (!url) {
|
||
showBanner("Repository URL is required.", "error");
|
||
return;
|
||
}
|
||
const body = { url };
|
||
if (branch) body.branch = branch;
|
||
// Only include token when admin typed one — empty string means "leave existing alone"
|
||
if (token) body.token = token;
|
||
try {
|
||
const r = await fetch(IW_API, {
|
||
method: "POST", credentials: "include",
|
||
headers: { "Content-Type": "application/json" },
|
||
body: JSON.stringify(body),
|
||
});
|
||
const data = await r.json().catch(() => ({}));
|
||
if (!r.ok) {
|
||
const detail = (data && data.detail) ? (typeof data.detail === "string" ? data.detail : JSON.stringify(data.detail)) : r.statusText;
|
||
showBanner("Save failed: " + detail, "error");
|
||
return;
|
||
}
|
||
closeModal("iw-modal");
|
||
showBanner("Initial Workspace Template saved. Click 'Sync now' to fetch the repo.", "success");
|
||
iwLoad();
|
||
} catch (e) {
|
||
showBanner("Save failed: " + e.message, "error");
|
||
}
|
||
}
|
||
|
||
async function iwSync() {
|
||
const btn = document.getElementById("iw-sync-btn");
|
||
btn.disabled = true;
|
||
btn.textContent = "Syncing…";
|
||
try {
|
||
const r = await fetch(IW_API + "/sync", {
|
||
method: "POST", credentials: "include",
|
||
});
|
||
const data = await r.json().catch(() => ({}));
|
||
if (!r.ok) {
|
||
const detail = (data && data.detail) ? data.detail : { kind: "unknown", message: r.statusText };
|
||
const msg = (typeof detail === "string")
|
||
? detail
|
||
: (detail.message || detail.kind || "Unknown error");
|
||
const kind = (typeof detail === "object") ? (detail.kind || "") : "";
|
||
document.getElementById("iw-sync-body").innerHTML =
|
||
`<div class="diff-row" style="color: #b91c1c;"><strong>Sync failed${kind ? " (" + escHtml(kind) + ")" : ""}:</strong><br>${escHtml(msg)}</div>`;
|
||
openModal("iw-sync-modal");
|
||
return;
|
||
}
|
||
document.getElementById("iw-sync-body").innerHTML =
|
||
`<div class="diff-row"><strong>Action:</strong> ${escHtml(data.action)}</div>
|
||
<div class="diff-row"><strong>Commit:</strong> <code>${escHtml(data.commit_sha)}</code></div>
|
||
<div class="diff-row"><strong>Files:</strong> ${data.file_count}</div>
|
||
<div class="diff-row"><strong>Path:</strong> <code>${escHtml(data.path)}</code></div>`;
|
||
openModal("iw-sync-modal");
|
||
} catch (e) {
|
||
document.getElementById("iw-sync-body").innerHTML =
|
||
`<div class="diff-row" style="color: #b91c1c;"><strong>Sync failed:</strong><br>${escHtml(e.message)}</div>`;
|
||
openModal("iw-sync-modal");
|
||
} finally {
|
||
btn.disabled = false;
|
||
btn.textContent = "Sync now";
|
||
iwLoad();
|
||
}
|
||
}
|
||
|
||
async function iwDelete() {
|
||
if (!confirm("Remove Initial Workspace Template? This restores the default `agnes init` flow. The on-disk working copy is also wiped.")) {
|
||
return;
|
||
}
|
||
try {
|
||
const r = await fetch(IW_API + "?purge=true", {
|
||
method: "DELETE", credentials: "include",
|
||
});
|
||
if (!r.ok) {
|
||
const data = await r.json().catch(() => ({}));
|
||
showBanner("Delete failed: " + (data.detail || r.statusText), "error");
|
||
return;
|
||
}
|
||
showBanner("Initial Workspace Template removed.", "success");
|
||
iwLoad();
|
||
} catch (e) {
|
||
showBanner("Delete failed: " + e.message, "error");
|
||
}
|
||
}
|
||
|
||
document.getElementById("iw-modal-save").addEventListener("click", iwSave);
|
||
iwLoad();
|
||
</script>
|
||
{% endblock %}
|