Comprehensive deploy safety audit implementing 19 improvements across CI/CD pipeline, test coverage, and source code. ### CI/CD Pipeline - ruff + mypy added to both release.yml and keboola-deploy.yml (continue-on-error) - Smoke test added to keboola-deploy.yml (was missing) - Automatic rollback on smoke test failure in release.yml - Expanded smoke-test.sh with catalog, admin/tables, marketplace.zip, metrics - Required status checks via .github/settings.yml - Dependabot + CODEOWNERS + pre-commit hooks + ruff config ### Source Code - DB schema version check in /api/health (db_schema: ok/mismatch/unhealthy) - Config versioning (config_version: 1 in instance.yaml, non-blocking validation) - BigQuery extractor ATTACH error handling (try/except around INSTALL+ATTACH) - Post-deploy smoke test script for prod VM validation ### Test Coverage (~50 new tests) - v13->v14 migration, Email magic link TTL, PAT, Marketplace ZIP/Git, Jira webhooks, Hybrid Query BQ, Keboola/BQ extractor failure modes, Orchestrator failure modes Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
182 lines
6.6 KiB
Bash
Executable file
182 lines
6.6 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
# Agnes smoke test — verifies a running instance is functional.
|
|
# Usage: ./scripts/smoke-test.sh [host:port]
|
|
# Default: http://localhost:8000
|
|
set -euo pipefail
|
|
|
|
HOST="${1:-http://localhost:8000}"
|
|
PASS=0
|
|
FAIL=0
|
|
TOKEN=""
|
|
|
|
check() {
|
|
local name="$1" ok="$2"
|
|
if [ "$ok" = "true" ]; then
|
|
echo " PASS $name"
|
|
PASS=$((PASS + 1))
|
|
else
|
|
echo " FAIL $name"
|
|
FAIL=$((FAIL + 1))
|
|
fi
|
|
}
|
|
|
|
echo "Smoke test: $HOST"
|
|
echo "---"
|
|
|
|
# 1. Health check (minimal, unauthenticated)
|
|
HEALTH=$(curl -sf "$HOST/api/health" | python3 -c "import sys,json; print(json.load(sys.stdin)['status'])" 2>/dev/null || echo "unreachable")
|
|
if [ "$HEALTH" = "unreachable" ]; then
|
|
echo " FATAL: health=$HEALTH"
|
|
exit 1
|
|
fi
|
|
check "health ($HEALTH)" "true"
|
|
|
|
# 1b. Unauthenticated DB-touching probe — exercises the system-DB path before
|
|
# any token is acquired. /api/health does NOT open system.duckdb (deliberate, so
|
|
# the LB probe stays cheap), so it can return 200 while every authed request
|
|
# 500s on permission/IO errors. /auth/email/request opens the users table to
|
|
# look up the email, which catches the foundryai-development class of
|
|
# regression (host-mounted /data root-owned, USER agnes can't open the DB).
|
|
# Accept anything in 200-499 — including 4xx for "email auth disabled" — but
|
|
# fail loudly on 5xx.
|
|
DB_PROBE=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$HOST/auth/email/request" \
|
|
-H "Content-Type: application/json" \
|
|
-d '{"email":"smoke-probe@test.local"}' 2>/dev/null || echo "000")
|
|
case "$DB_PROBE" in
|
|
5*|000) check "db-touching probe (HTTP $DB_PROBE — expected non-5xx)" "false" ;;
|
|
*) check "db-touching probe (HTTP $DB_PROBE)" "true" ;;
|
|
esac
|
|
|
|
# 2. Health detailed has version fields (requires auth, checked after bootstrap)
|
|
|
|
# 3. Bootstrap (only works on fresh DB; 403 means users exist)
|
|
BOOT_HTTP=$(curl -s -o /tmp/smoke_boot.json -w "%{http_code}" -X POST "$HOST/auth/bootstrap" \
|
|
-H "Content-Type: application/json" \
|
|
-d '{"email":"smoke@test.local","name":"Smoke Test","password":"SmokeTest123!"}' 2>/dev/null || echo "000")
|
|
|
|
if [ "$BOOT_HTTP" = "200" ]; then
|
|
TOKEN=$(python3 -c "import json; print(json.load(open('/tmp/smoke_boot.json'))['access_token'])" 2>/dev/null || echo "")
|
|
check "bootstrap (new admin)" "true"
|
|
elif [ "$BOOT_HTTP" = "403" ]; then
|
|
# Users exist — operator must supply SMOKE_TOKEN to validate the authed
|
|
# paths, otherwise the script would silently SKIP every regression.
|
|
TOKEN="${SMOKE_TOKEN:-}"
|
|
if [ -z "$TOKEN" ]; then
|
|
check "bootstrap (users exist; SMOKE_TOKEN required to continue)" "false"
|
|
else
|
|
echo " SKIP bootstrap (users exist; using SMOKE_TOKEN)"
|
|
fi
|
|
else
|
|
check "bootstrap (HTTP $BOOT_HTTP)" "false"
|
|
fi
|
|
|
|
# 2b. Health detailed (authenticated) — version fields
|
|
if [ -n "$TOKEN" ]; then
|
|
HAS_VERSION=$(curl -sf "$HOST/api/health/detailed" \
|
|
-H "Authorization: Bearer $TOKEN" | python3 -c "
|
|
import sys,json
|
|
d=json.load(sys.stdin)
|
|
print('true' if 'version' in d and 'channel' in d and 'schema_version' in d else 'false')
|
|
" 2>/dev/null || echo "false")
|
|
check "health detailed version fields" "$HAS_VERSION"
|
|
fi
|
|
|
|
# 4. Query SELECT 1 (requires auth)
|
|
if [ -n "$TOKEN" ]; then
|
|
QUERY_OK=$(curl -sf -X POST "$HOST/api/query" \
|
|
-H "Authorization: Bearer $TOKEN" \
|
|
-H "Content-Type: application/json" \
|
|
-d '{"sql":"SELECT 1 as test"}' | python3 -c "
|
|
import sys,json
|
|
d=json.load(sys.stdin)
|
|
print('true' if len(d.get('rows',[])) > 0 else 'false')
|
|
" 2>/dev/null || echo "false")
|
|
check "query SELECT 1" "$QUERY_OK"
|
|
else
|
|
echo " SKIP query (no token)"
|
|
fi
|
|
|
|
# 5. Sync trigger
|
|
if [ -n "$TOKEN" ]; then
|
|
SYNC_HTTP=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$HOST/api/sync/trigger" \
|
|
-H "Authorization: Bearer $TOKEN" 2>/dev/null || echo "000")
|
|
if [[ "$SYNC_HTTP" =~ ^(200|202)$ ]]; then
|
|
check "sync trigger" "true"
|
|
else
|
|
check "sync trigger (HTTP $SYNC_HTTP)" "false"
|
|
fi
|
|
else
|
|
echo " SKIP sync (no token)"
|
|
fi
|
|
|
|
# 6. Post-sync health (wait briefly)
|
|
sleep 5
|
|
if [ -n "$TOKEN" ]; then
|
|
HEALTH2=$(curl -sf "$HOST/api/health/detailed" \
|
|
-H "Authorization: Bearer $TOKEN" | python3 -c "import sys,json; print(json.load(sys.stdin)['status'])" 2>/dev/null || echo "unreachable")
|
|
else
|
|
HEALTH2=$(curl -sf "$HOST/api/health" | python3 -c "import sys,json; print(json.load(sys.stdin)['status'])" 2>/dev/null || echo "unreachable")
|
|
fi
|
|
if [ "$HEALTH2" = "unhealthy" ] || [ "$HEALTH2" = "unreachable" ]; then
|
|
check "post-sync health ($HEALTH2)" "false"
|
|
else
|
|
check "post-sync health ($HEALTH2)" "true"
|
|
fi
|
|
|
|
# 7. Catalog endpoint (authenticated)
|
|
if [ -n "$TOKEN" ]; then
|
|
CATALOG_HTTP=$(curl -s -o /tmp/smoke_catalog.json -w "%{http_code}" "$HOST/api/catalog" \
|
|
-H "Authorization: Bearer $TOKEN" 2>/dev/null || echo "000")
|
|
if [[ "$CATALOG_HTTP" =~ ^(200|404)$ ]]; then
|
|
check "catalog endpoint (HTTP $CATALOG_HTTP)" "true"
|
|
else
|
|
check "catalog endpoint (HTTP $CATALOG_HTTP)" "false"
|
|
fi
|
|
else
|
|
echo " SKIP catalog (no token)"
|
|
fi
|
|
|
|
# 8. Admin tables endpoint (authenticated)
|
|
if [ -n "$TOKEN" ]; then
|
|
TABLES_HTTP=$(curl -s -o /tmp/smoke_tables.json -w "%{http_code}" "$HOST/api/admin/tables" \
|
|
-H "Authorization: Bearer $TOKEN" 2>/dev/null || echo "000")
|
|
if [[ "$TABLES_HTTP" =~ ^(200|403)$ ]]; then
|
|
check "admin tables endpoint (HTTP $TABLES_HTTP)" "true"
|
|
else
|
|
check "admin tables endpoint (HTTP $TABLES_HTTP)" "false"
|
|
fi
|
|
else
|
|
echo " SKIP admin tables (no token)"
|
|
fi
|
|
|
|
# 9. Marketplace.zip endpoint (with PAT auth if available)
|
|
MARKETPLACE_PAT="${AGNES_PAT:-${SMOKE_PAT:-}}"
|
|
if [ -n "$MARKETPLACE_PAT" ]; then
|
|
MARKET_HTTP=$(curl -s -o /tmp/smoke_marketplace.zip -w "%{http_code}" "$HOST/api/marketplace.zip" \
|
|
-H "Authorization: Bearer $MARKETPLACE_PAT" 2>/dev/null || echo "000")
|
|
if [[ "$MARKET_HTTP" =~ ^(200|304|404)$ ]]; then
|
|
check "marketplace.zip (HTTP $MARKET_HTTP)" "true"
|
|
else
|
|
check "marketplace.zip (HTTP $MARKET_HTTP)" "false"
|
|
fi
|
|
else
|
|
echo " SKIP marketplace.zip (no PAT — set AGNES_PAT or SMOKE_PAT to test)"
|
|
fi
|
|
|
|
# 10. Metrics endpoint (authenticated)
|
|
if [ -n "$TOKEN" ]; then
|
|
METRICS_HTTP=$(curl -s -o /tmp/smoke_metrics.json -w "%{http_code}" "$HOST/api/metrics" \
|
|
-H "Authorization: Bearer $TOKEN" 2>/dev/null || echo "000")
|
|
if [[ "$METRICS_HTTP" =~ ^(200|404)$ ]]; then
|
|
check "metrics endpoint (HTTP $METRICS_HTTP)" "true"
|
|
else
|
|
check "metrics endpoint (HTTP $METRICS_HTTP)" "false"
|
|
fi
|
|
else
|
|
echo " SKIP metrics (no token)"
|
|
fi
|
|
|
|
# Results
|
|
echo ""
|
|
echo "Results: $PASS passed, $FAIL failed"
|
|
[ "$FAIL" -eq 0 ] || exit 1
|