1563b05f2e
Task 0.5 of clean-analyst-bootstrap. Greenfield rewrite — no fallback, no aliases. Existing dev environments lose their cached PAT and must re-authenticate. Env var renames (hard cutover): - DA_CONFIG_DIR -> AGNES_CONFIG_DIR - DA_SERVER -> AGNES_SERVER - DA_SERVER_URL -> AGNES_SERVER_URL (test-only stale ref, not in spec) - DA_NO_UPDATE_CHECK -> AGNES_NO_UPDATE_CHECK - DA_LOCAL_DIR -> AGNES_LOCAL_DIR - DA_TOKEN -> AGNES_TOKEN - DA_STREAM_RETRIES -> AGNES_STREAM_RETRIES Config dir rename: ~/.config/da/ -> ~/.config/agnes/ (across code, comments, docstrings, error messages, install templates, dev scripts). Stale `da X` references in CLI source (and adjacent app/, tests/): swept docstrings, comments, help text, and error messages where the verb survives the rewrite (init, pull, push, catalog, status, diagnose, auth, admin, skills, query, schema, describe, explore, disk-info, snapshot, login, logout, whoami, server, setup) and replaced `da X` with `agnes X`. Intentionally kept `da sync`, `da fetch`, `da analyst`, `da metrics` — those verbs are removed in later tasks; the legacy strings will be detected by `_LEGACY_STRINGS` (added in Task 2). Test fixes: - TestCLIVersion now asserts output starts with `agnes ` (was `da `). Test results: 2675 passed, 25 skipped (full pytest run, excluding 9 pre-existing test_db.py / test_user_management.py / test_e2e_extract.py / test_cli_binary_rename.py failures unrelated to this rename).
75 lines
2.9 KiB
Python
75 lines
2.9 KiB
Python
"""POST /api/query for a table id that's registered as
|
|
`query_mode='materialized'` but isn't yet a view in `analytics.duckdb`
|
|
returns a helpful, materialize-aware error instead of a raw "Table does
|
|
not exist" string from DuckDB.
|
|
|
|
E2E sub-agent finding 2026-05-01: `agnes query --remote "SELECT * FROM
|
|
e2e2_synced_table LIMIT 5"` on a synced materialized table failed with
|
|
DuckDB's bare error message even though the table is in the registry.
|
|
The fix improves the surfaced message so the operator sees the
|
|
materialize-mode hint without having to decode DuckDB internals.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from src.repositories.table_registry import TableRegistryRepository
|
|
|
|
|
|
def _auth(token: str) -> dict:
|
|
return {"Authorization": f"Bearer {token}"}
|
|
|
|
|
|
def test_query_materialized_id_not_in_views_returns_helpful_message(seeded_app):
|
|
"""An admin querying a materialized id that isn't yet materialized in
|
|
the local analytics.duckdb gets a 400 whose detail names the
|
|
query_mode and points at `da sync` / direct-BQ-query."""
|
|
from src.db import get_system_db
|
|
sys_conn = get_system_db()
|
|
try:
|
|
TableRegistryRepository(sys_conn).register(
|
|
id="not_yet_materialized",
|
|
name="not_yet_materialized",
|
|
source_type="bigquery",
|
|
query_mode="materialized",
|
|
source_query='SELECT 1 FROM bq."ds"."t"',
|
|
bucket="ds",
|
|
source_table="t",
|
|
)
|
|
finally:
|
|
sys_conn.close()
|
|
|
|
c = seeded_app["client"]
|
|
token = seeded_app["admin_token"]
|
|
r = c.post(
|
|
"/api/query",
|
|
json={"sql": "SELECT * FROM not_yet_materialized LIMIT 5"},
|
|
headers=_auth(token),
|
|
)
|
|
assert r.status_code == 400, r.json()
|
|
detail = str(r.json().get("detail", ""))
|
|
# Message should name the table and surface the materialize-mode hint.
|
|
assert "not_yet_materialized" in detail
|
|
assert "materialized" in detail.lower()
|
|
# Either a `da sync` hint or a direct-BQ-query hint must appear so the
|
|
# operator has a concrete next step.
|
|
assert "da sync" in detail or "bq." in detail
|
|
|
|
|
|
def test_query_unknown_table_falls_back_to_default_error(seeded_app):
|
|
"""Sanity: a query for a table that isn't even in the registry still
|
|
surfaces DuckDB's error verbatim (no false positive on the new hint
|
|
path). RBAC's 403 path takes precedence for non-admin callers; for
|
|
admins (no RBAC filter) the table simply doesn't exist as a view, and
|
|
the query falls through to DuckDB's "does not exist" message."""
|
|
c = seeded_app["client"]
|
|
token = seeded_app["admin_token"]
|
|
r = c.post(
|
|
"/api/query",
|
|
json={"sql": "SELECT * FROM totally_unknown_table"},
|
|
headers=_auth(token),
|
|
)
|
|
assert r.status_code == 400, r.json()
|
|
detail = str(r.json().get("detail", "")).lower()
|
|
# Falls back to the generic query-error path; no materialized hint.
|
|
assert "materialized" not in detail
|