agnes-the-ai-analyst/tests/test_cli_catalog.py
ZdenekSrotyr 1563b05f2e refactor(cli): hard-cutover env vars + config dir to AGNES_*
Task 0.5 of clean-analyst-bootstrap. Greenfield rewrite — no fallback,
no aliases. Existing dev environments lose their cached PAT and must
re-authenticate.

Env var renames (hard cutover):
- DA_CONFIG_DIR    -> AGNES_CONFIG_DIR
- DA_SERVER        -> AGNES_SERVER
- DA_SERVER_URL    -> AGNES_SERVER_URL  (test-only stale ref, not in spec)
- DA_NO_UPDATE_CHECK -> AGNES_NO_UPDATE_CHECK
- DA_LOCAL_DIR     -> AGNES_LOCAL_DIR
- DA_TOKEN         -> AGNES_TOKEN
- DA_STREAM_RETRIES -> AGNES_STREAM_RETRIES

Config dir rename: ~/.config/da/ -> ~/.config/agnes/ (across code,
comments, docstrings, error messages, install templates, dev scripts).

Stale `da X` references in CLI source (and adjacent app/, tests/):
swept docstrings, comments, help text, and error messages where the
verb survives the rewrite (init, pull, push, catalog, status, diagnose,
auth, admin, skills, query, schema, describe, explore, disk-info,
snapshot, login, logout, whoami, server, setup) and replaced `da X`
with `agnes X`. Intentionally kept `da sync`, `da fetch`, `da analyst`,
`da metrics` — those verbs are removed in later tasks; the legacy
strings will be detected by `_LEGACY_STRINGS` (added in Task 2).

Test fixes:
- TestCLIVersion now asserts output starts with `agnes ` (was `da `).

Test results: 2675 passed, 25 skipped (full pytest run, excluding 9
pre-existing test_db.py / test_user_management.py / test_e2e_extract.py
/ test_cli_binary_rename.py failures unrelated to this rename).
2026-05-04 16:35:44 +02:00

168 lines
5.7 KiB
Python

# tests/test_cli_catalog.py
import json
from typer.testing import CliRunner
from unittest.mock import patch
import typer
import pytest
def test_da_catalog_json_output(monkeypatch):
"""`agnes catalog --json` emits the server's JSON verbatim."""
payload = {
"tables": [
{"id": "orders", "name": "orders", "source_type": "keboola",
"query_mode": "local", "sql_flavor": "duckdb",
"where_examples": [], "fetch_via": "...", "rough_size_hint": None},
],
"server_time": "2026-04-27T17:30:00Z",
}
with patch("cli.commands.catalog.api_get_json", return_value=payload):
from cli.commands.catalog import catalog_app
runner = CliRunner()
result = runner.invoke(catalog_app, ["--json"])
assert result.exit_code == 0
out = json.loads(result.stdout)
assert out["tables"][0]["id"] == "orders"
def test_da_catalog_table_output(monkeypatch):
payload = {
"tables": [
{"id": "orders", "name": "orders", "source_type": "keboola",
"query_mode": "local", "sql_flavor": "duckdb",
"where_examples": [], "fetch_via": "...", "rough_size_hint": None},
],
"server_time": "2026-04-27T17:30:00Z",
}
with patch("cli.commands.catalog.api_get_json", return_value=payload):
from cli.commands.catalog import catalog_app
runner = CliRunner()
result = runner.invoke(catalog_app, [])
assert result.exit_code == 0
assert "orders" in result.stdout
assert "keboola" in result.stdout
def test_da_schema_json_output():
"""agnes schema <table> --json emits column metadata as JSON."""
payload = {
"table_id": "orders",
"source_type": "keboola",
"sql_flavor": "duckdb",
"columns": [
{"name": "id", "type": "INTEGER", "nullable": False, "description": "Primary key"},
{"name": "total", "type": "DOUBLE", "nullable": True, "description": "Order total"},
],
"partition_by": None,
"clustered_by": [],
"where_dialect_hints": {},
}
with patch("cli.commands.schema.api_get_json", return_value=payload):
from cli.commands.schema import schema_app
runner = CliRunner()
result = runner.invoke(schema_app, ["--json", "orders"])
assert result.exit_code == 0
out = json.loads(result.stdout)
assert out["table_id"] == "orders"
assert len(out["columns"]) == 2
def test_da_schema_human_output():
"""agnes schema <table> shows human-readable column listing."""
payload = {
"table_id": "orders",
"source_type": "keboola",
"sql_flavor": "duckdb",
"columns": [
{"name": "id", "type": "INTEGER", "nullable": False, "description": "PK"},
],
"partition_by": None,
"clustered_by": [],
"where_dialect_hints": {},
}
with patch("cli.commands.schema.api_get_json", return_value=payload):
from cli.commands.schema import schema_app
runner = CliRunner()
result = runner.invoke(schema_app, ["orders"])
assert result.exit_code == 0
assert "orders" in result.stdout
assert "id" in result.stdout
assert "INTEGER" in result.stdout
def test_da_schema_error_exits_nonzero():
"""agnes schema propagates V2ClientError and exits with non-zero code."""
from cli.v2_client import V2ClientError
with patch("cli.commands.schema.api_get_json", side_effect=V2ClientError(status_code=404, body="not found")):
from cli.commands.schema import schema_app
runner = CliRunner()
result = runner.invoke(schema_app, ["nonexistent"])
assert result.exit_code != 0
def test_da_describe_json_output():
"""agnes describe <table> --json emits schema + sample as JSON."""
schema_payload = {
"table_id": "orders",
"source_type": "keboola",
"sql_flavor": "duckdb",
"columns": [
{"name": "id", "type": "INTEGER", "nullable": False, "description": "PK"},
],
"partition_by": None,
"clustered_by": [],
"where_dialect_hints": {},
}
sample_payload = {
"table_id": "orders",
"rows": [{"id": 1}, {"id": 2}],
"columns": ["id"],
}
def fake_get(path, **kwargs):
if "schema" in path:
return schema_payload
return sample_payload
with patch("cli.commands.describe.api_get_json", side_effect=fake_get):
from cli.commands.describe import describe_app
runner = CliRunner()
result = runner.invoke(describe_app, ["--json", "orders"])
assert result.exit_code == 0
out = json.loads(result.stdout)
assert "schema" in out
assert "sample" in out
assert out["schema"]["table_id"] == "orders"
def test_da_describe_human_output():
"""agnes describe <table> shows schema + sample in human-readable form."""
schema_payload = {
"table_id": "orders",
"source_type": "keboola",
"sql_flavor": "duckdb",
"columns": [
{"name": "id", "type": "INTEGER", "nullable": False, "description": "PK"},
],
"partition_by": None,
"clustered_by": [],
"where_dialect_hints": {},
}
sample_payload = {
"table_id": "orders",
"rows": [{"id": 1}],
"columns": ["id"],
}
def fake_get(path, **kwargs):
if "schema" in path:
return schema_payload
return sample_payload
with patch("cli.commands.describe.api_get_json", side_effect=fake_get):
from cli.commands.describe import describe_app
runner = CliRunner()
result = runner.invoke(describe_app, ["orders"])
assert result.exit_code == 0
assert "orders" in result.stdout
assert "id" in result.stdout