agnes-the-ai-analyst/tests/test_telegram_bot.py
ZdenekSrotyr 863453b2e2 fix: address code review findings — duplicate fixture, JWT key length, async deprecation
- Remove duplicate mock_extract_factory fixture in conftest.py
- Use 32+ char JWT_SECRET_KEY everywhere (was 15 chars, triggered warnings)
- Replace deprecated asyncio.get_event_loop() with asyncio.run()
- Unify WebhookEventFactory sign methods (consistent json.dumps)
2026-04-13 13:47:51 +02:00

98 lines
4.2 KiB
Python

"""Tests for Telegram bot message handlers."""
import asyncio
import os
import sys
from unittest.mock import AsyncMock, patch
import pytest
# bot.py creates a FileHandler at module-level import. Ensure the
# directory exists so import doesn't fail in CI environments.
_data_dir = os.environ.get("DATA_DIR", "/data")
os.makedirs(os.path.join(_data_dir, "notifications"), exist_ok=True)
try:
from services.telegram_bot.bot import handle_message # noqa: F401
_BOT_AVAILABLE = True
except Exception:
_BOT_AVAILABLE = False
pytestmark = pytest.mark.skipif(
not _BOT_AVAILABLE,
reason="services.telegram_bot.bot could not be imported (missing log dir or dependency)",
)
def _make_message(text: str, chat_id: int = 10) -> dict:
return {"chat": {"id": chat_id}, "text": text}
def _run(coro):
"""Run a coroutine synchronously."""
return asyncio.run(coro)
class TestHandleMessage:
def test_start_unlinked_user_generates_verification_code(self):
"""'/start' for an unlinked user generates and sends a verification code."""
with (
patch("services.telegram_bot.bot.get_username_by_chat_id", return_value=None),
patch("services.telegram_bot.bot.create_verification_code", return_value="123456") as mock_code,
patch("services.telegram_bot.bot.send_message", new_callable=AsyncMock) as mock_send,
):
from services.telegram_bot.bot import handle_message
_run(handle_message(_make_message("/start", chat_id=10)))
mock_code.assert_called_once_with(10)
mock_send.assert_called_once()
sent_text = mock_send.call_args[0][1]
assert "123456" in sent_text
def test_start_already_linked_user_no_code(self):
"""'/start' for an already-linked user does NOT generate a new code."""
with (
patch("services.telegram_bot.bot.get_username_by_chat_id", return_value="alice"),
patch("services.telegram_bot.bot.create_verification_code") as mock_code,
patch("services.telegram_bot.bot.send_message", new_callable=AsyncMock),
):
from services.telegram_bot.bot import handle_message
_run(handle_message(_make_message("/start", chat_id=10)))
mock_code.assert_not_called()
def test_help_returns_help_text(self):
"""'/help' sends a message containing help information."""
with patch("services.telegram_bot.bot.send_message", new_callable=AsyncMock) as mock_send:
from services.telegram_bot.bot import handle_message
_run(handle_message(_make_message("/help", chat_id=20)))
mock_send.assert_called_once()
sent_text = mock_send.call_args[0][1]
assert "/start" in sent_text
assert "/help" in sent_text
def test_unknown_command_sends_unknown_response(self):
"""An unknown command sends an 'Unknown command' reply."""
with patch("services.telegram_bot.bot.send_message", new_callable=AsyncMock) as mock_send:
from services.telegram_bot.bot import handle_message
_run(handle_message(_make_message("/foobar", chat_id=30)))
mock_send.assert_called_once()
sent_text = mock_send.call_args[0][1]
assert "Unknown" in sent_text or "unknown" in sent_text
def test_message_with_no_chat_id_is_ignored(self):
"""A message without a chat id does nothing."""
with patch("services.telegram_bot.bot.send_message", new_callable=AsyncMock) as mock_send:
from services.telegram_bot.bot import handle_message
_run(handle_message({"text": "/help"}))
mock_send.assert_not_called()
def test_whoami_linked_user_sends_username(self):
"""'/whoami' for a linked user sends the username."""
with (
patch("services.telegram_bot.bot.get_username_by_chat_id", return_value="dave"),
patch("services.telegram_bot.bot.send_message", new_callable=AsyncMock) as mock_send,
):
from services.telegram_bot.bot import handle_message
_run(handle_message(_make_message("/whoami", chat_id=40)))
mock_send.assert_called_once()
sent_text = mock_send.call_args[0][1]
assert "dave" in sent_text