AI-Cognitive-Leap/agnes-the-ai-analyst
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(cli): #168 review iter 4 — render reason when both kind+reason set

Browse source 
Devin Review iter #4 caught: `_format_dict` in cli/error_render.py
seeded `seen = {"kind", "reason"}` to keep both out of the kv block.
But the label line uses only ONE of them (`kind or reason or "error"`),
so the other was silently dropped.

Quota rejections at app/api/query.py:423 (daily-budget) and 488
(concurrent-slot) emit BOTH keys: `{reason: "daily_byte_cap_exceeded",
kind: "daily_bytes", ...}` and `{reason: "concurrent_slot_exceeded",
kind: "concurrent_scans", ...}`. Operator only saw `kind` in the label
and never the more specific `reason` value.

Fix: track which key actually went into the label and skip only that
one. The other appears in the kv section.

Verified output:
  Error: daily_bytes (HTTP 429)
    reason: daily_byte_cap_exceeded
    current: 99999
    ...

8 affected render tests pass.
This commit is contained in:
ZdenekSrotyr 2026-05-04 14:04:16 +02:00
parent 28aba4c1f9
commit a43533ca44
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
cli/error_render.py
View file

@ -63,11 +63,20 @@ def _detail_dict(body: Any) -> dict | None:
def _format_dict(status_code: int, detail: dict) -> str:
"""Multi-line render of a recognized typed-error dict."""
label = detail.get("kind") or detail.get("reason") or "error"
"""Multi-line render of a recognized typed-error dict.
When both `kind` and `reason` are present (e.g. quota rejections at
`app/api/query.py` carry `{reason: "daily_byte_cap_exceeded",
kind: "daily_bytes", ...}`), the label line shows only one — the
other must still appear in the key/value section so its value isn't
silently dropped. Devin Review iter #4 caught this.
"""
label_key = "kind" if detail.get("kind") else ("reason" if detail.get("reason") else None)
label = detail.get(label_key) if label_key else "error"
lines: list[str] = [f"Error: {label} (HTTP {status_code})"]
seen: set[str] = {"kind", "reason"} # already in the label line
# Only the key actually used in the label is hidden from the kv block.
seen: set[str] = {label_key} if label_key else set()
# Priority keys first
for key in _PRIORITY_KEYS:
if key in seen: