AI-Cognitive-Leap/agnes-the-ai-analyst
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(db): apply bq_query_timeout_ms to read-only reattach path

Browse source 
Devin Review on PR #181: caught that the original PR plumbed the new
SET into the orchestrator's _remote_attach (rebuild path), the BqAccess
factory (materialize path), and the standalone extractor — but missed
the actual primary `agnes query --remote` request path: every read-only
analytics-DB connection runs `_reattach_remote_extensions` in `src/db.py`
on open, and that LOAD bigquery + ATTACH cycle was unconfigured.

Without this commit, the very flow the PR was meant to fix — analyst
queries hitting BQ views > 90s — would still 400 with the same Binder
Error / Job ID wording, because the runtime LOAD bigquery happens here
not in the orchestrator's rebuild path.

Apply apply_bq_session_settings(conn) right after the BQ secret is
created and before ATTACH, mirroring what every other PR site does.
This commit is contained in:
ZdenekSrotyr 2026-05-05 16:27:48 +02:00
parent 4f04235502
commit 025a2b5c0e
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/db.py
View file

@ -614,6 +614,8 @@ def _reattach_remote_extensions(
f"CREATE OR REPLACE SECRET {secret_name} " f"CREATE OR REPLACE SECRET {secret_name} "
f"(TYPE bigquery, ACCESS_TOKEN '{escaped}')" f"(TYPE bigquery, ACCESS_TOKEN '{escaped}')"
) )
from connectors.bigquery.access import apply_bq_session_settings
apply_bq_session_settings(conn)
conn.execute( conn.execute(
f"ATTACH '{safe_url}' AS {alias} (TYPE {extension}, READ_ONLY)" f"ATTACH '{safe_url}' AS {alias} (TYPE {extension}, READ_ONLY)"
) )